Fix macOS availability #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenSorial
force-pushed
the
fix-macos-availability
branch
from
f407ad7
to
aafc166
Compare
|
@Stevenmagdy Sorry for the late reply! Thanks for the PR; looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS availability for version 1.0 in
name_availability.plistis 10.15. but initializers for both Image and NSImage actually has requirement of 11.0, alsoSFSymbols.apphas macOS minimum for version 1.0 as 11.0.The reason for why it's written as 10.15 in
name_availability.plistis unknown but if I have to guess, the font was privately available in 10.15 for catalyst apps compatibility. Whatever the reason is, we should have the same requirements as the initializers.