-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildsystem: fix build for macOS #25
Conversation
tusharpm
commented
Jan 13, 2018
- use minimum required flex version 2.6 (Apple gives an older version built-in)
- fix linker flag for Apple
- use minimum required flex version 2.6 (Apple gives an older version built-in) - fix linker flag for Apple
- the default treatment of `-undefined` is `error` for `ld` on Apple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I had locally just hardcoded the APPLE conditional here with intent to conditionalize later. However if you'd prefer to keep parity there (at least my issue was with Clang not accepting those flags) consider using something like this which I believe is equivalent:
+ # for Clang the options are different
+ set_target_properties(nyan PROPERTIES LINK_FLAGS "-Wl,-undefined,error")
Thanks for the review. 👍 About the specification of the link flag: I have that in my first commit. However, in my opinion, these flags are better left as implicit defaults if they're favorable. On macOS, |
@tusharpm OK - that's fine by me. It seems doubtful that the defaults there will change any time soon, and I favor minimalism. Maybe note that in a comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should do.