Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SLP v4.2 format #1284

Closed
heinezen opened this issue Aug 23, 2020 · 0 comments · Fixed by #1336
Closed

Support SLP v4.2 format #1284

heinezen opened this issue Aug 23, 2020 · 0 comments · Fixed by #1336
Labels
area: assets Involved with assets (images, sounds, ...) good first issue Suitable for newcomers lang: python Done in Python code
Projects
convert

Comments

@heinezen
Copy link
Member

heinezen commented Aug 23, 2020 •
edited

Required skills: Python, Cython

Difficulty: Easy

Age of Empires 1: Definitive Edition - Update 38862 introduced a new iteration of the SLP format. SLP v4.2 (documented here) is technically just a LZ4 compressed SLP v4.0/v4.1 file with two additional header values. Thus, we only need to implement LZ4 decompression into our current SLP reader code. There already exists a Python library that we could use:

Further reading:
@heinezen heinezen added area: assets Involved with assets (images, sounds, ...) good first issue Suitable for newcomers lang: python Done in Python code labels Aug 23, 2020
@heinezen heinezen added this to output in convert Aug 23, 2020
@heinezen heinezen mentioned this issue Aug 23, 2020
Open
@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Oct 5, 2020
@heinezen heinezen mentioned this issue Oct 17, 2020
Closed
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 4, 2020
@heinezen heinezen mentioned this issue Nov 7, 2020
Merged
convert automation moved this from output to done Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) good first issue Suitable for newcomers lang: python Done in Python code
Projects
No open projects
convert
  
done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SLP v4.2 export heinezen/openage
1 participant
@heinezen