[Linux] build error

[werdahias]

cloned the repo and configured it. when running make I get the following error:

[ 23%] Building CXX object libopenage/CMakeFiles/libopenage.dir/event/demo/main.cpp.o
/home/user/openage/libopenage/event/demo/gui.cpp: In member function ‘void openage::event::demo::Gui::init()’:
/home/user/openage/libopenage/event/demo/gui.cpp:136:25: error: format not a string literal and no format arguments [-Werror=format-security]
  136 |                 mvprintw(row++, col, c);
      |                 ~~~~~~~~^~~~~~~~~~~~~~~
/home/user/openage/libopenage/event/demo/gui.cpp: In member function ‘void openage::event::demo::Gui::draw(const std::shared_ptr<openage::event::demo::PongState>&, const time_t&)’:
/home/user/openage/libopenage/event/demo/gui.cpp:209:25: error: format not a string literal and no format arguments [-Werror=format-security]
  209 |                 mvprintw((6 + msg_i), state->display_boundary[0]/2 + 10, msg.c_str());
      |                 ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 23%] Building CXX object libopenage/CMakeFiles/libopenage.dir/event/demo/physics.cpp.o

Then the build fails. OS is debian testing and gcc 11

[TheJJ]

I mean it's true that we don't pass a format string to mvprintw, which could be a problem if the user could enter arbitrary msgs.
Since I don't see a function like mvput, we probably have to introduce a artificial format string to make the compiler happy and prevent format-string-interpretation of generated input:

• mvprintw(a, b, c) -> mvprintw(a, b, "%c", c)
• mvprintw(a, b, s) -> mvprintw(a, b, "%s", s)...

[werdahias]

I fixed it by appending two lines in gui.cpp

diff --git a/libopenage/event/demo/gui.cpp b/libopenage/event/demo/gui.cpp
index f6fa6e2e..0724f63a 100644
--- a/libopenage/event/demo/gui.cpp
+++ b/libopenage/event/demo/gui.cpp
@@ -133,7 +133,7 @@ void Gui::init() {
 	int row = (y - buffer.size()) / 2;;
 	int col = (x - colwidth) / 2;
 	for (const auto &c : buffer) {
-		mvprintw(row++, col, c);
+		mvprintw(row++, col, "%c", c);
 	}
 
 	attroff(COLOR_PAIR(COLOR_DEBUG));
@@ -206,7 +206,7 @@ void Gui::draw(const std::shared_ptr<PongState> &state, const curve::time_t &now
 	// show log
 	int msg_i = 0;
 	for (auto & msg : this->log_msgs) {
-		mvprintw((6 + msg_i), state->display_boundary[0]/2 + 10, msg.c_str());
+		mvprintw((6 + msg_i), state->display_boundary[0]/2 + 10, "%msg.c_str()", msg.c_str() );
 		msg_i += 1;
 	}
 :

Then it compiles succesfully

[TheJJ]

great :)
the second hunk's string should be "%s" though.
can you submit a pull request to bring this fix upstream?

[FabioLolix]

Hello, I have the same error on Arch Linux, GCC 11.1.0 and Clang 13.0.1

[ 25%] Building CXX object libopenage/CMakeFiles/libopenage.dir/gamedata/tech_dummy.cpp.o
/home/fabio/Dev/Github/PKGBUILD/openage-git/src/openage/libopenage/event/demo/gui.cpp:136:24: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
                mvprintw(row++, col, c);
                                     ^
/home/fabio/Dev/Github/PKGBUILD/openage-git/src/openage/libopenage/event/demo/gui.cpp:136:24: note: treat the string as an argument to avoid this
                mvprintw(row++, col, c);
                                     ^
                                     "%s", 
/home/fabio/Dev/Github/PKGBUILD/openage-git/src/openage/libopenage/event/demo/gui.cpp:209:60: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
                mvprintw((6 + msg_i), state->display_boundary[0]/2 + 10, msg.c_str());
                                                                         ^~~~~~~~~~~
/home/fabio/Dev/Github/PKGBUILD/openage-git/src/openage/libopenage/event/demo/gui.cpp:209:60: note: treat the string as an argument to avoid this
                mvprintw((6 + msg_i), state->display_boundary[0]/2 + 10, msg.c_str());
                                                                         ^
                                                                         "%s", 
[ 25%] Building CXX object libopenage/CMakeFiles/libopenage.dir/gamedata/terrain_dummy.cpp.o

---

Tried your patches, they're working