Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: HD 4.0 patch compatibility #318

Closed
goto-bus-stop opened this issue Jun 23, 2015 · 8 comments
Closed

convert: HD 4.0 patch compatibility #318

goto-bus-stop opened this issue Jun 23, 2015 · 8 comments
Labels
just do it You can start working on this, there should be nothing left to discuss lang: python Done in Python code to-discuss Idea or suggestion that needs some discussion before implementation

Comments

@goto-bus-stop
Copy link
Contributor

The HD Edition 4.0 patch changed a lot in data file storage. For example, DRS files are a thing of the past. The good part is that the new storage format is like, a million times better. The bad part is that the openage conversion script no longer works for up-to-date HD installations, and needs more special cases, probably.

I'll have time to work on this in a bit over a week, but if somebody else wants to pick it up in the mean time, feel free 😄

@franciscod
Copy link
Contributor

Are we still supporting the old format?

@goto-bus-stop
Copy link
Contributor Author

I'd say yes, at least for a while. The 4.0 patch is very buggy so a lot of people are still on 3.9.

@janisozaur
Copy link
Contributor

and for original release of the game as well?

@detrumi
Copy link
Contributor

detrumi commented Jun 24, 2015

It's probably best to keep supporting the original release, as we don't want to force people to buy the HD version if they already have the old version.

We can drop 3.9 support after a while, for example when 4.1 or something comes out, as most people will update their game. But that depends on how much has changed between versions. If it's just small changes, we can keep old versions in.

@goto-bus-stop
Copy link
Contributor Author

Yeah, absolutely, the original releases should be supported. In fact, the original releases might still be more common than HD at this point among people who want to install openage 😜 4.0 support would be in addition to all other releases that are currently supported, just like how HD support itself was an extra thing.

HD 3.9 support isn't particularly complex, it's the same as the original release except for a few changed paths and different language files. It's basically free to support so we should support it until literally nobody is on pre-4.0 HD editions anymore

@TheJJ TheJJ added lang: python Done in Python code to-discuss Idea or suggestion that needs some discussion before implementation just do it You can start working on this, there should be nothing left to discuss labels Jun 24, 2015
@TheJJ
Copy link
Member

TheJJ commented Jun 24, 2015

We have #61 for this to support all kinds of input configs and select them automatically. #288 will bring a filesystem abstraction comparable to physFS, so we will be able to use the version detection to mount all the archives (including drs) transparently for the then-following conversion.
We can support the .cab files from the iso the same way as the new folder structure that way \o/!

@mic-e
Copy link
Member

mic-e commented Jun 25, 2015

If anyone wants to work on this, please base your work on the current pyinterface branch.

There have been so many changes and simplifications that merging your patch would pretty much result in a re-write.

@TheJJ
Copy link
Member

TheJJ commented Aug 11, 2015

should be fixed by #340 now

@TheJJ TheJJ closed this as completed Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
just do it You can start working on this, there should be nothing left to discuss lang: python Done in Python code to-discuss Idea or suggestion that needs some discussion before implementation
Projects
None yet
Development

No branches or pull requests

6 participants