New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github action tests #264
Conversation
By disabling the distutils deprecation warning. This workaround will work only up to Python 3.12
Straight from #261 which somehow never got merged.
Okay, aside from the distutils problem, there were quite a few more problems that needed fixing:
Caveats:
Both issues are better resolved by someone that can more easily reproduce the issue locally and fix all them in one go (instead of having to push and wait for the result of the windows CI). |
The python check fails due to a deprecation warning (distutils).
It seems the recommended way forward is to use sysconfig instead. That should be mostly straightforward as only SGppConfigure.py is affected. However, apparently moving from distutils to sysconfig can be a bit quirky on some platforms (for example here). Not quite sure how relevant those issues still are since it has been a while since I looked into it.
Until we can get around to use sysconfig (and more importantly, test it on all platforms we care about), this PR provides a quick workaround for the build issues with python 3.10 and 3.11 by simply disabling the deprecation warning. However, this will of course only work up until python 3.12 as distutils will be gone then.
See issue #263