Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add checksums to diagnostics #126

Closed
wants to merge 1 commit into from
Closed

feat: Add checksums to diagnostics #126

wants to merge 1 commit into from

Conversation

YannickdeHoop
Copy link
Contributor

No description provided.

@YannickdeHoop
Copy link
Contributor Author

Hi @puck-fzi,
In this PR i want to add the configuration checksums to the diagnostics. However this checksum will only be read from the device on startup. We may want to poll it because the configuration could be changed, what do you think?
In the configuration tool of the nanoscan the checksums are read big endian. So to have the same checksum in the driver we should also read it big endian.

@YannickdeHoop
Copy link
Contributor Author

ping @puck-fzi

@puck-fzi
Copy link
Collaborator

puck-fzi commented Jun 1, 2023

Hi, i would say, reading it at startup of the driver might be sufficient for now. If it appears not to be, polling could be added later

@puck-fzi
Copy link
Collaborator

puck-fzi commented Jun 1, 2023

Merged

@puck-fzi puck-fzi closed this Jun 1, 2023
@puck-fzi puck-fzi added the Merged label Jun 1, 2023
@reinzor reinzor mentioned this pull request Jul 24, 2023
Closed
@nicostudt nicostudt mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YannickdeHoop @puck-fzi @reinzor