feat: SA-429 Add options support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-sigtech
force-pushed
the
SA-429_options_support
branch
4 times, most recently
from
bbee9fe
to
fd07169
Compare
jake-sigtech
force-pushed
the
SA-429_options_support
branch
4 times, most recently
from
8dd95a2
to
f2e1a3d
Compare
jake-sigtech
force-pushed
the
SA-429_options_support
branch
from
f2e1a3d
to
c0325c7
Compare
jake-sigtech
force-pushed
the
SA-429_options_support
branch
2 times, most recently
from
e2d2aa1
to
eb1271b
Compare
sbroadfoot
reviewed
Jun 28, 2024
| isinstance(strike, (float, int)) | ||
| or ( | ||
| isinstance(strike, str) | ||
| and re.match(r"^(SPOT|FWD)([+-]\d{1,2}%)?$", strike) |
There was a problem hiding this comment.
Should we also support ATM here to match v9?
There was a problem hiding this comment.
I don't think the v9 supports this.
There was a problem hiding this comment.
I do not think any of the strings are supported atm when creating the option directly. But looks like it should be supported with the get_option .
There was a problem hiding this comment.
I get this error with the FX get_option
There was a problem hiding this comment.
Similarly with the Equity-Index case
There was a problem hiding this comment.
I was thinking of the spot and forward strike types.
There was a problem hiding this comment.
I have raised an error
jake-sigtech
force-pushed
the
SA-429_options_support
branch
from
eb1271b
to
4ffaa64
Compare
sbroadfoot
previously approved these changes
Jul 2, 2024
jake-sigtech
force-pushed
the
SA-429_options_support
branch
from
4ffaa64
to
76ba8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.