Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENTITIES_SERVICE_ACCESS_TOKEN env var #110

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Apr 8, 2024

Closes #108

This can be set to avoid doing OAuth2 authentication for the CLI, for example when using the CLI in connection with CI/CD.

This can be set to avoid doing OAuth2 authentication for the CLI, for
example when using the CLI in connection with CI/CD.
This is to avoid circular imports.
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 89.90826% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 88.08%. Comparing base (0c280c7) to head (f5828a6).

Files Patch % Lines
entities_service/service/security.py 85.13% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   88.75%   88.08%   -0.67%     
==========================================
  Files          21       21              
  Lines        1094     1192      +98     
==========================================
+ Hits          971     1050      +79     
- Misses        123      142      +19     
Flag Coverage Δ
docker ?
local 88.08% <89.90%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA CasperWA requested a review from Treesarj April 9, 2024 09:41
@CasperWA CasperWA enabled auto-merge (squash) April 9, 2024 11:28
@CasperWA CasperWA merged commit 4128798 into main Apr 9, 2024
10 of 11 checks passed
@CasperWA CasperWA deleted the cwa/close-108-support-access-tokens branch April 9, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔐 Support supplying access token to upload
2 participants