Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with missing dependencies #85

Closed
wants to merge 1 commit into from
Closed

Conversation

quaat
Copy link

@quaat quaat commented Feb 9, 2024

Upon installing according to the README, I ran into some missing dependencies. This PR fixes this issue.

@quaat quaat requested a review from CasperWA February 9, 2024 09:11
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00d274c) 91.36% compared to head (ae20093) 91.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files          17       17           
  Lines        1007     1007           
=======================================
  Hits          920      920           
  Misses         87       87           
Flag Coverage Δ
docker 71.00% <ø> (ø)
local 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CasperWA
Copy link
Collaborator

Ah, sorry. The README should be updated, not the dependencies.
The CLI should work fine when installing with the cli extra, i.e., pip install entities-service[cli]

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README with specific installations instructions for using the CLI instead of changing the core dependencies.

@CasperWA
Copy link
Collaborator

No response. Going to close this, creating an issue in the wake for updating the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants