Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added params for exclude coords and limit to get recent in client #13

Conversation

karlssonerik
Copy link
Contributor

No description provided.

Copy link
Contributor

@albinrydberg albinrydberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should strife for unit-testing our libraries, so that we don't have to release and hope for the best. But I'll leave it for you to decide.

@j-sv
Copy link
Contributor

j-sv commented Aug 16, 2021

I agree with @albinrydberg that we should have unit tests, but given that we're still in 0.x releases I think we add unit testing boiler plate as a separate PR and enforce tests after that. Will be a lot of unrelated changes necessary to get unit testing in and part of CI.

@karlssonerik karlssonerik merged commit f67654e into master Aug 16, 2021
@karlssonerik karlssonerik deleted the feature/add-exculde-coords-and-limit-options-to-get-recent branch August 16, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants