Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimizing install-deps-*.sh execution time #26

Merged
merged 1 commit into from Oct 30, 2017
Merged

Minimizing install-deps-*.sh execution time #26

merged 1 commit into from Oct 30, 2017

Conversation

LeeHayun
Copy link
Contributor

@LeeHayun LeeHayun commented Oct 16, 2017 •
edited

This PR is part of #25. (+alpha)

Major Changes

  • Remove face detection API (temporary)
  • install-deps-*.sh (ANT's own Docker Image #28)
    • Remove unused GStreamer packages
    • Utilize multi-core
    • Replace some build stages to package installation
      • libxml2, OpenCV, nodejs-4.x

Minor Changes

  • Add Apache LICENSE for Camera Framework
  • Fix raspberry pi camera-config.json

TODO

  • I will implement face detection on the ML framework.

@sinban04 sinban04 mentioned this pull request Oct 17, 2017
Merged
RedCarrottt
RedCarrottt reviewed Oct 17, 2017
View reviewed changes
Copy link
Member

@RedCarrottt RedCarrottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does this version work with current face detection API?

@LeeHayun
Copy link
Contributor Author

@RedCarrottt
This version does not support face detection.

The haar classifier used for face detection is one of the machine learning techniques.
I removed face detection in the current version because I want face detection to be a feature of the ML framework.
When developing ML framework core is completed, I will add face detection API as ML API.

@sinban04 sinban04 mentioned this pull request Oct 17, 2017
Closed
2 tasks
sinban04
sinban04 approved these changes Oct 17, 2017
View reviewed changes
Copy link
Contributor

@sinban04 sinban04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LeeHayun LeeHayun force-pushed the master branch 5 times, most recently from 21648aa to f8a8e1f Compare October 17, 2017 16:04
@RedCarrottt
Copy link
Member

After you complete this PR, please merge commits with git rebase command.

@LeeHayun LeeHayun force-pushed the master branch 2 times, most recently from 7af3242 to 77cf661 Compare October 28, 2017 07:56
@LeeHayun LeeHayun changed the title Use OpenCV package instead of dep installation Minimizing install-deps-*.sh execution time Oct 28, 2017
@LeeHayun
Minimize the install-deps-*.sh execution time
a305a2f 
* Add Apache LICENSE for Camera Framework
* Remove face detection API (temporary)
* Fix raspberry pi camera-config.json
* Remove unused GStreamer packages
* Utilize multi-core (in prerequisite installation time)
@LeeHayun
Copy link
Contributor Author

Finally, I tested on raspberry pi 3.
Below is the execution time of install-deps-raspberry-pi2_3.sh.

time

Actually, each execution time is as follows.

step 1~2 step 3~11
about 10 mins about 10 mins

In my environment, git clone is very slow.

@RedCarrottt
Copy link
Member

How nice! 👍

@jong1prk
Copy link
Contributor

LGTM
Finally, annoying problem is solved.
Thanks!

@jong1prk jong1prk merged commit 4853601 into SKKU-ESLAB:master Oct 30, 2017
@sinban04 sinban04 mentioned this pull request Nov 1, 2017
Closed
LeeHayun pushed a commit that referenced this pull request Dec 3, 2022
@jong1prk
Merge pull request #26 from LeeHayun/master
95cd80c 
Minimizing install-deps-*.sh execution time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedCarrottt RedCarrottt RedCarrottt approved these changes

@sinban04 sinban04 sinban04 approved these changes

@jong1prk jong1prk Awaiting requested review from jong1prk

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeeHayun @RedCarrottt @jong1prk @sinban04