Skip to content

Commit

Permalink
fix: ensure binary executable when packaged in vsix
Browse files Browse the repository at this point in the history
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch main
# Your branch is up to date with 'origin/main'.
#
# Changes to be committed:
#

modified:   scripts/build_vsix.sh
#
# Untracked files:
#	commit_convention.yaml
#	demos/neovim/
#	scripts/scratch_build.sh
#	scripts/split_debug.sh
#	scripts/strip_bin.sh
#
  • Loading branch information
SKalt committed Jan 23, 2024
1 parent 01f6c0f commit 7bd0873
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions scripts/build_vsix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ build_vsix() {
mkdir -p "$dist_dir"
log_dbug "copying orignial bin $original_bin_path -> $dist_dir/cconvention"
cp "$original_bin_path" "$dist_dir/cconvention"
chmod +x "$dist_dir/cconvention" # ensure the binary is executable
rm -f "$vsix_path" # just in case
# see https://github.com/microsoft/vscode-vsce/issues/421 for issues with vsce+pnpm
log_info "building $vsix_path"
Expand Down

0 comments on commit 7bd0873

Please sign in to comment.