Compatibility of legends in make_frame

[Yuming-Zhang]

Hi,

I think make_frame works very well when we add plots on it. The only issue I find out for this moment is that, make_frame seems to have some issue with the location of legend of the original plot.

For example, please try the below code:
Xt = gen_gts(300, AR(phi = c(0, 0, 0.8), sigma2 = 1))
model = arima(Xt, order = c(3,0,0), include.mean = T)
resid_plot(Xt, model, std = FALSE, type = "hist")

As you can see the plot will have legend in the very topright, which should be included inside the white space.

@munsheet Do you think we can modify the make_frame function a bit to have it compatible with legends? Please let me know if I can help in any way! Thanks a lot! :)

[munsheet]

custom_legend() should work the same as legend()

Try running the above lines again.

Xt = gen_gts(300, AR(phi = c(0, 0, 0.8), sigma2 = 1))
model = arima(Xt, order = c(3,0,0), include.mean = T)
resid_plot(Xt, model, std = FALSE, type = "hist")

I replaced all legend() with custom_legend() in simts for now.

Note that any time you want to add a legend with a make_frame() plot, you also need to use custom_legend()

Please close this issue if this issue seems to be fixed.