Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate more French words into English #373

Merged
merged 2 commits into from
May 2, 2024

Conversation

sunxiaoguang
Copy link
Contributor

There are some more words can be translated into English

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@SMEWebify SMEWebify self-requested a review May 1, 2024 19:10
@SMEWebify SMEWebify added the Blade Pull requests that update blade code label May 1, 2024
@SMEWebify SMEWebify added this to In progress in v1.09 - Pieris ergane via automation May 1, 2024
@@ -142,7 +142,7 @@
'label_trans_key' => 'Label',
'customer_trans_key' => 'Customer',
'status_trans_key' => 'Status',
'statu_trans_key' => 'Statu',
'statu_trans_key' => 'Status',
Copy link
Owner

@SMEWebify SMEWebify May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot accept this line, there is statu and status with an "s" for the plural (line just before) if I maintain, it is duplicates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, But I guess there is no Statu in English, What can we do with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave the discussion for future. This line is reverted, please take another look.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state or progress would be more appropriate? I validate the pull request and we will see how it is used later,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess state and status are pretty similar. The only issue is that they are not related like it is in French.

I can totally understand the meaning of Statu in UI, even though it's not English. Let's keep it as it is.

@SMEWebify SMEWebify self-assigned this May 1, 2024
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@SMEWebify SMEWebify merged commit 4c095c1 into SMEWebify:WEM-2.0 May 2, 2024
1 check passed
v1.09 - Pieris ergane automation moved this from In progress to Done May 2, 2024
@SMEWebify SMEWebify moved this from Done to Integrated on demo site in v1.09 - Pieris ergane May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blade Pull requests that update blade code
Projects
No open projects
v1.09 - Pieris ergane
Integrated on demo site
Development

Successfully merging this pull request may close these issues.

None yet

2 participants