-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the SR anonymisation #1524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
+ Coverage 58.87% 59.44% +0.56%
==========================================
Files 185 185
Lines 6546 6650 +104
Branches 913 946 +33
==========================================
+ Hits 3854 3953 +99
- Misses 2161 2443 +282
+ Partials 531 254 -277 ☔ View full report in Codecov by Sentry. |
…s PN) plus a few which may contain an address (to be used in new anonymiser, see CogStack-SemEHR)
…[Other Names]] header
…om a single-element list
…ilename for JSON input because JSON from dcm2json is more verbose than the MongoDB JSON
…e "PersonName" tags in the JSON to match the code in the DicomText module. As used by the CogStack-SemEHR anonymiser.py code.
for more information, see https://pre-commit.ci
…ines just like CTP_DicomToText.py otherwise redaction offsets wouldn't match
jas88
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Improve the anonymisation by collecting real names from anywhere in the text (i.e. those contained in a unique DICOM element with a value representation of
PN
orPersonName
as MongoDB calls it) and anonymise any parts of those names anywhere in the text, as long as those parts of names are 4 or more characters long. Previously only top-levelPN
elements were collected.Add a test program which can generate SRs with real names randomly inserted, so you can check that the anonymiser successfully redacts them.
The anonymiser changes are in
Types of changes
What types of changes does your code introduce? Tick all that apply.
[skip ci]
Checklist
By opening this PR, I confirm that I have: