Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the SR anonymisation #1524

Merged
merged 23 commits into from
Nov 20, 2023
Merged

Improve the SR anonymisation #1524

merged 23 commits into from
Nov 20, 2023

Conversation

howff
Copy link
Contributor

@howff howff commented Apr 19, 2023

Proposed Changes

Improve the anonymisation by collecting real names from anywhere in the text (i.e. those contained in a unique DICOM element with a value representation of PN or PersonName as MongoDB calls it) and anonymise any parts of those names anywhere in the text, as long as those parts of names are 4 or more characters long. Previously only top-level PN elements were collected.

Add a test program which can generate SRs with real names randomly inserted, so you can check that the anonymiser successfully redacts them.

The anonymiser changes are in

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

@howff howff marked this pull request as draft April 19, 2023 21:30
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efcc850) 58.87% compared to head (20f4d62) 59.44%.
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   58.87%   59.44%   +0.56%     
==========================================
  Files         185      185              
  Lines        6546     6650     +104     
  Branches      913      946      +33     
==========================================
+ Hits         3854     3953      +99     
- Misses       2161     2443     +282     
+ Partials      531      254     -277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@howff howff changed the title Help to test the SR anonymisation Improve the SR anonymisation Oct 25, 2023
@howff howff self-assigned this Nov 14, 2023
@howff howff marked this pull request as ready for review November 14, 2023 10:35
@howff howff requested a review from rkm November 14, 2023 10:35
@howff howff added the enhancement New feature or request label Nov 14, 2023
@howff howff requested a review from jas88 November 20, 2023 14:46
@jas88 jas88 merged commit 6a34417 into master Nov 20, 2023
23 checks passed
@jas88 jas88 deleted the feature/srmod branch November 20, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants