Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functional.py #328

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Update functional.py #328

merged 2 commits into from
Aug 18, 2023

Conversation

liyown
Copy link
Contributor

@liyown liyown commented Jul 24, 2023

Optimized for slow segmentation of data when the Dilliclet coefficient is small,According to this issue #230, but it might be difficult to replicate the results reported in the original paper.

Optimized for slow segmentation of data when the Dilliclet coefficient is small,According to this issue #230, but it might be difficult to replicate the results reported in the original paper.
@liyown
Copy link
Contributor Author

liyown commented Jul 24, 2023

In the code, if the number of samples for a category is 0, it will result in a process of randomly re-selecting the category. The code adds an exception handling mechanism to ensure that sample selection continues even if the number of samples for a category is 0. For example, when the sample number of a class is 0, a class with a non-zero sample number is randomly selected for sample selection.

@AgentDS
Copy link
Member

AgentDS commented Aug 16, 2023

Hi, Sorry for the late reply.
Could you please rename the new version of the function as client_inner_dirichlet_partition_faster, and keep the old version of the function with the old name? so we can keep both versions for this function.

 add the function  "client_inner_dirichlet_partition_faster"
@liyown
Copy link
Contributor Author

liyown commented Aug 17, 2023

Modified

@AgentDS AgentDS merged commit ee91d3f into SMILELab-FL:master Aug 18, 2023
1 check passed
@AgentDS
Copy link
Member

AgentDS commented Aug 18, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants