Add example encoder config option #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltkb
approved these changes
Jun 14, 2024
SMILEY4
reviewed
Jun 15, 2024
| @@ -34,7 +29,7 @@ class ExampleContextImpl : ExampleContext { | |||
| */ | |||
| fun add(routes: Collection<RouteMeta>) { | |||
| collectExampleDescriptors(routes).forEach { exampleDescriptor -> | |||
| rootExamples[exampleDescriptor] = generateExample(exampleDescriptor) | |||
| rootExamples[exampleDescriptor] = exampleDescriptor | |||
There was a problem hiding this comment.
i think i am missing why we need to generate the example in the getter and not here. Couldn't collectExampleDescriptors return the descriptor together with a type so that we can generate the final swagger Example object here?
There was a problem hiding this comment.
did the thing, maybe you can merge and release soon 🙂
|
Hi @SMILEY4, is there anything I can help with to get this PR merged? |
thank you and sorry for the delay. PR looks good in my opinion - there is an open question of understanding from my side but i think we can still merge it. I'll try to close it soon and release a new version for it. |
rChaoz
force-pushed
the
feat/examples-encoder
branch
from
738581a
to
aec52a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105