-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added gradient-enhanced neural nets (genn) #126
Conversation
❌ Build SMT 0.2.467 failed (commit 17ce5081a0 by @) |
❌ Build SMT 0.2.468 failed (commit 408e0ce07a by @) |
✅ Build SMT 0.2.469 completed (commit 99c0dfedf8 by @) |
Pull Request Test Coverage Report for Build 456
💛 - Coveralls |
✅ Build SMT 0.2.472 completed (commit 294914f709 by @shb84) |
In order to increase coverage, there exist additional tests within most of the neural_net files that could potentially be incorporated. These are implemented after the "if name == 'main'" statement. Please let me know how I can help increase coverage. |
Indeed you should exclude "main parts" from coverage and add tests under smt/tests and mimic what is done for other surrogates. You can run coverage in your dev environment to check for improvement. |
❌ Build SMT 0.2.473 failed (commit c773c0ffca by @) |
❌ Build SMT 0.2.474 failed (commit c8d357a956 by @) |
❌ Build SMT 0.2.475 failed (commit 328c90f0e7 by @shb84) |
✅ Build SMT 0.2.476 completed (commit b7ee7bd6d5 by @) |
It looks like the reason the Travis CI build failed is not related to neural net additions, but has to do with "smt/tests/test_high_dim.py:Test.test_tanh_QP ... FAIL" instead. Please let me know if any additional corrections are needed on the neural net side. |
❌ Build SMT 0.2.487 failed (commit e1c3413bef by @) |
Sorry for the late reply. This is the first time in 6 weeks that I've had a chance to work on the code. I sincerely appreciate the feedback. Thank you. |
❌ Build SMT 0.2.488 failed (commit 10d7a337ec by @shb84) |
✅ Build SMT 0.2.493 completed (commit 41d8012dda by @bouhlelma) |
This pull request includes new files that implement gradient-enhanced neural nets using numpy. The original code was not modified, except for "test_surrogate_model_examples.py" where I added a test for GENN. The newly added files are as follows: