Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ordinal and Integer constraints in DesignSpace #525

Merged
merged 10 commits into from
Mar 4, 2024

Conversation

Paul-Saves
Copy link
Contributor

@Paul-Saves Paul-Saves commented Feb 29, 2024

  • Remove scaling and normalization for categorical variables in MFK
  • Ruff and black the code
  • Fix several mixed integer tests that were badly setup
  • Add rounding in design_space for integer, ordinal or categorical variables
  • Add a new ConfigSpace object (cs_vars_cate) that is fully categorical such that Integer and Ordinal Variables can take into account the design constraints defined in the original object (cs_vars). It ain't clean but it's a good workaround for now to deal with ConfigSpace 0.6.1.
  • Add tests to check that Integer or Ordinal variables constraints are well taken into account!

* update ds

* fix test

* fix

* fix

* fix mfk mixed

* fix finallygit add -u !

* fix
@Paul-Saves Paul-Saves marked this pull request as draft February 29, 2024 18:39
@Paul-Saves Paul-Saves closed this Mar 1, 2024
@Paul-Saves Paul-Saves reopened this Mar 1, 2024
@Paul-Saves Paul-Saves changed the title [DRAFT] Fix Ordinal and Integer constraints in DesignSpace Fix Ordinal and Integer constraints in DesignSpace Mar 1, 2024
@Paul-Saves Paul-Saves marked this pull request as ready for review March 1, 2024 08:34
@relf relf merged commit 7faf76a into SMTorg:master Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants