New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup of the POD+I application #547
Conversation
…edict_values...etc.
…to the other surrogate models
Currently fixing the failed test by using ruff. Doing a new pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. As discussed, you had to add some tests.
smt/applications/podi.py
Outdated
""" | ||
choice_svd = None | ||
|
||
svd = PCA(svd_solver="randomized", random_state=random_state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could not also use TruncatedSVD
to leverage on the number of modes
A "podpg.py" file has been created to perform this new method. Some changes have been made to other files as well.