Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup of the POD+I application #547

Merged
merged 40 commits into from Apr 26, 2024
Merged

Setup of the POD+I application #547

merged 40 commits into from Apr 26, 2024

Conversation

Shisohka
Copy link
Contributor

A "podpg.py" file has been created to perform this new method. Some changes have been made to other files as well.

@Shisohka
Copy link
Contributor Author

Currently fixing the failed test by using ruff. Doing a new pull request soon.

@Shisohka Shisohka closed this Apr 15, 2024
@Shisohka Shisohka reopened this Apr 15, 2024
Copy link
Member

@relf relf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As discussed, you had to add some tests.

smt/surrogate_models/ipython.html Outdated Show resolved Hide resolved
smt/surrogate_models/krg_based.py Outdated Show resolved Hide resolved
@Shisohka Shisohka marked this pull request as draft April 18, 2024 13:00
smt/applications/podi.py Outdated Show resolved Hide resolved
smt/applications/podi.py Show resolved Hide resolved
smt/applications/podi.py Show resolved Hide resolved
"""
choice_svd = None

svd = PCA(svd_solver="randomized", random_state=random_state)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could not also use TruncatedSVD to leverage on the number of modes

smt/surrogate_models/ipython.html Outdated Show resolved Hide resolved
smt/applications/podi.py Outdated Show resolved Hide resolved
smt/applications/podi.py Outdated Show resolved Hide resolved
@Shisohka Shisohka changed the title Setup of the POD+GP surrogate model Setup of the POD+I surrogate model Apr 25, 2024
smt/applications/tests/test_podi.py Show resolved Hide resolved
smt/applications/tests/test_podi.py Outdated Show resolved Hide resolved
@Shisohka Shisohka marked this pull request as ready for review April 25, 2024 13:54
@Shisohka Shisohka changed the title Setup of the POD+I surrogate model Setup of the POD+I application Apr 25, 2024
@relf relf merged commit 457940a into SMTorg:master Apr 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants