Skip to content

Commit

Permalink
Fix electron security vulnerabilities
Browse files Browse the repository at this point in the history
  • Loading branch information
@SMUnlimited
SMUnlimited committed Oct 5, 2022
1 parent d7d42ba commit a8472f0
Show file tree
Hide file tree
Showing 3 changed files with 21,573 additions and 193 deletions.
22 changes: 20 additions & 2 deletions Electron/app/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 comments on commit a8472f0

@jzy-chitong56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to use this is still unknown……In other words, I don't know what's the use……

@paulo101977
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to use this is still unknown……In other words, I don't know what's the use……

electron is a native application build using javascript. That is, I create an app that runs on an operating system. In this app, it replaces the installer we used with bash, either from perl or other bashs.

@paulo101977
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMUnlimited, typically these vulnerability issues attack web systems. As our install is run locally, these issues will not affect the final application.

@jzy-chitong56
Copy link
Contributor

@jzy-chitong56 jzy-chitong56 commented on a8472f0 Oct 5, 2022 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulo101977
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I only can use EXE or BAT··· But I don't seem to see them This is... more embarrassing

Is that the executable will only be available when there is the first deploy by @SMUnlimited.

Meanwhile, if you want to run electron locally, you'll have to follow the steps to run it. I left it in the README

@jzy-chitong56
Copy link
Contributor

@jzy-chitong56 jzy-chitong56 commented on a8472f0 Oct 5, 2022 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMUnlimited
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMUnlimited, typically these vulnerability issues attack web systems. As our install is run locally, these issues will not affect the final application.

Indeed, but was simple to fix in this case and stops github screaming at me for now.

@paulo101977
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but was simple to fix in this case and stops github screaming at me for now.

Yes, they keep piling up vulnerability notifications.

Please sign in to comment.