Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styles not specific enough. #7

Closed
danmarsden opened this issue Mar 25, 2022 · 1 comment
Closed

styles not specific enough. #7

danmarsden opened this issue Mar 25, 2022 · 1 comment

Comments

@danmarsden
Copy link

in your styles.css you define a number of generic styles that could clash with core moodle code or other locations where simliar names are used.

Moodle helpfully adds a number of classes to the body tag based on the path that you can use such as:
eg if you are have a file in mod/assign you would see the following class added to the body tag
path-mod-assign
so if you have an item with the class "filething" on the page you would target it like:

.path-mod-assign .filething {
   color: red;
}

Please make sure your css classes in styles.css are specific enough so they cannot clash with other core code.

@danmarsden
Copy link
Author

this doesn't seem to have been addressed. - I still see generic styles within your plugin that are not specific enough "autolink_popup" is too generic - if you are adding new classes specific to your filter you should be using classes that are specific to your plugin - like including the word "recitautolink" instead of just "autolink"

emilevirus added a commit that referenced this issue May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants