Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_model convenience function #225

Closed
JostMigenda opened this issue Oct 13, 2022 · 4 comments · Fixed by #353
Closed

init_model convenience function #225

JostMigenda opened this issue Oct 13, 2022 · 4 comments · Fixed by #353
Assignees
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion wontfix This will not be worked on

Comments

@JostMigenda
Copy link
Member

The init_model convenience function was added in #184 to try out; but is currently hidden in snewpy.models.util, which is (a) not included in the docs and (b) probably not a submodule that we’d want to expose to the user.

There’s also Andrey’s comment about whether to require e.g. "ccsn.Nakazato_2013" as an argument instead of just "Nakazato_2013".

@JostMigenda JostMigenda added the suggestion An idea that needs to be discussed/approved before starting implementaion label Oct 13, 2022
@JostMigenda
Copy link
Member Author

I’ve moved the function to snewpy.models in #230.

@JostMigenda JostMigenda mentioned this issue Nov 17, 2022
2 tasks
@JostMigenda
Copy link
Member Author

Also: Should this still use the get_models downloader (which downloads all progenitors for that model family) or should it use the new downloader (which only loads the requested progenitor)?

@JostMigenda
Copy link
Member Author

Almost two years later, we’ve never actually needed this convenience function; so let’s remove this dead code.

@JostMigenda JostMigenda self-assigned this Aug 12, 2024
@sybenzvi sybenzvi added the wontfix This will not be worked on label Aug 13, 2024
@sybenzvi
Copy link
Contributor

Remove the stub code (@JostMigenda ) and then close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants