Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_model convenience function #225

Open
JostMigenda opened this issue Oct 13, 2022 · 2 comments
Open

init_model convenience function #225

JostMigenda opened this issue Oct 13, 2022 · 2 comments
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion

Comments

@JostMigenda
Copy link
Member

The init_model convenience function was added in #184 to try out; but is currently hidden in snewpy.models.util, which is (a) not included in the docs and (b) probably not a submodule that we’d want to expose to the user.

There’s also Andrey’s comment about whether to require e.g. "ccsn.Nakazato_2013" as an argument instead of just "Nakazato_2013".
@JostMigenda JostMigenda added the suggestion An idea that needs to be discussed/approved before starting implementaion label Oct 13, 2022
@JostMigenda JostMigenda mentioned this issue Oct 14, 2022
Merged
@JostMigenda
Copy link
Member Author

I’ve moved the function to snewpy.models in #230.

@JostMigenda JostMigenda mentioned this issue Nov 17, 2022
Merged
2 tasks
@JostMigenda
Copy link
Member Author

Also: Should this still use the get_models downloader (which downloads all progenitors for that model family) or should it use the new downloader (which only loads the requested progenitor)?

JostMigenda added a commit that referenced this issue Apr 30, 2024
@JostMigenda
remove unnecessary use of get_models in undocumented internal function
bcd9306 
See #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JostMigenda