Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate times from Bollig_2016 s27.0c files #168

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

svalder
Copy link

@svalder svalder commented Jan 5, 2022

Similar to PR #161 the s27.0c files in Bollig_2016 had multiple lines with the exact same time stamp. This in turn causes an error in scipy.interpolate.pchip.

This PR deletes these lines following the resolution in PR #161.

Note: the mean energy are very similar but the luminosities in each example appear higher.

@sybenzvi sybenzvi self-requested a review January 5, 2022 17:57
@JostMigenda
Copy link
Member

Hm … unit tests all succeed and the integration tests themselves also succeed; the failure occurs in the last step (posting benchmark results here) and is unrelated to this change. (Though unfortunately, the error message is vague enough that I can’t tell what it is related to.) So I’d suggest we go ahead, merge this PR and then wait until the next PR to see whether this is a temporary issue and resolves itself or whether we need to fix the integration test workflow?

@sybenzvi
Copy link
Contributor

sybenzvi commented Jan 5, 2022

I agree @JostMigenda, I can't figure out why the integration test fails and there is no good reason why this change is at fault. I will try to merge the branch anyway.

@sybenzvi sybenzvi merged commit e7334d2 into SNEWS2:main Jan 5, 2022
@svalder svalder deleted the Valder-BolligDuplicate branch January 5, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants