-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a dictionary of keyword arguments for SN models + added code for ROOT output #171
Conversation
Thanks @soso128! I see you’ve already added the docstrings—excellent! Unfortunately, it looks like you accidentally included some unrelated changes to Regarding part 2: ROOT is a very heavy dependency (in terms of time and disk space to install) and, in my experience, quite fragile when it comes to binary compatibility with different versions of Python. So I would be very hesitant before depending on it for a core feature of SNEWPY. Since this code also appears to duplicate a lot of the code from |
Ok, done. Indeed it would be better to write a code in scripts/ for the ROOT output. I'll do this. |
I just added a script for the ROOT output (and removed the previous code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this to a script! It looks good, I just have a few minor suggestions to make it a little clearer to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now; many thanks @soso128 for being so responsive! And congratulations on your first contribution to SNEWPY! 🎉
This pull request contains two commits:
1- Added an argument to generate_time_series and generate_fluence in snowglobes.py: this dictionary allows to give keyword arguments to define SN models (EOS, etc...)
2- Added a new code to get ROOT 2D histograms for the rates, instead of collated text files