Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Quantum Decoherence in vacuum #260

Merged
merged 13 commits into from
Nov 22, 2023
Merged

Conversation

santosmv
Copy link
Contributor

The effects are combined with the MSW effect. In this case, the flavor conversion from quantum decoherence happens in vacuum (as in the MSC^e of arXiv:2306.17591), and no Earth matter effects are included in this version.

Copy link
Collaborator

@mcolomermolla mcolomermolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use the QD class without problems in a FlavorTransformation notebook to build the flux and spectrum, which follows the expected trend from the paper. I did not find any issue with the flavor transition probabilities implementation, it follows the same scheme as for the other (i.e. AdiabaticSW). To me, this PR is good to go.

@JostMigenda
Copy link
Member

Sorry for the delay! I just ran the unit tests (GitHub doesn't run them automatically for PRs from first-time contributors, I think) and unfortunately, these are currently failing; it looks like some issue with units. @santosmv, can you please take a look at this?

@santosmv
Copy link
Contributor Author

Sure, I'll take a look at this.

@santosmv
Copy link
Contributor Author

It was just missing units of quantum decoherence parameters in the test_04_xforms.py. Upon running this test, some issues were raised in the assertEqual methods, which were also fixed.

@JostMigenda
Copy link
Member

Just added a minor edit to clean up some unnecessary unit conversions. (Usually, AstroPy handles those automatically as needed; manual conversions are mainly needed at the end to format for output.)

Otherwise, @mcolomermolla already posted an approving review above; so now that the test succeed, I’ll go ahead and merge. Many thanks @santosmv for your work and congratulations on your first SNEWPY PR! 🎉

@JostMigenda JostMigenda merged commit 939e81b into SNEWS2:main Nov 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants