v1.5 release #329
Merged
v1.5 release #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numpy <1.16 required Python <=3.7, which we don’t support anymore; so this restriction is redundant
Due to a bug in earlier SNOwGLoBES versions (SNOwGLoBES/snowglobes#28), snewpy wouldn’t load efficiency files for ar40kt and produce this warning: > python/snewpy/rate_calculator.py:389: UserWarning: Efficiency not found for detector=ar40kt, channel=nue_Ar40_he. Using 100% efficiency (Note the `_he` in the channel name!) With snowglobes_data 1.3.2, snewpy finds the correct efficiency file. This leads to a lower efficiency and we lose some events. This commit updates the rate_table with the new event counts.
* use absolute URL to snewpy logo (relative URLs break when README is displayed on PyPI) * Jupyter notebooks for models were moved to new directory in #313
Sheshuk
approved these changes
May 4, 2024
| echo "PYTHON_VERSION=${PYTHON_VERSION}" | ||
| GIT_VERSION=${GITHUB_REF/refs\/tags\/v/} | ||
| echo "GIT_VERSION=${GIT_VERSION}" | ||
| if [ $PYTHON_VERSION != $GIT_VERSION ]; then exit 1; fi |
There was a problem hiding this comment.
I really like this versions check, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for the v1.5 release.
Note: Because of a bug in SNOwGLoBES v1.3.1 and earlier (where
channels_argon.datwould incorrectly refer to_hechannels), SNEWPY would not find the efficiency files and assume a fixed efficiency of 100%.With the fix in SNOwGLoBES v1.3.2, SNEWPY now finds the correct efficiency files, so the total event count for the
ar40ktdetector is about 5% lower than in previous versions.