Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ccsn_loaders.py #331

Closed
wants to merge 1 commit into from
Closed

Update ccsn_loaders.py #331

wants to merge 1 commit into from

Conversation

jpkneller
Copy link
Contributor

I think there's an error in lines 60-63. It should be _flav.name not flavor.name

I think there's an error in lines 60-63. It should be _flav.name not flavor.name
@JostMigenda
Copy link
Member

Could you explain why?

The model input files don’t distinguish nu_x and nu_x_bar, so _flav is used when constructing the filename to read the nu_x_bar flux from the nu_x file. But after reading the data, outside code shouldn’t have to care about whether the input files distinguish the two. So I think it makes sense to use flavor everywhere else, like we do now?

@jpkneller
Copy link
Contributor Author

Aah, I was looking at an old version. Forget this PR.

@JostMigenda
Copy link
Member

No worries!

@JostMigenda JostMigenda closed this May 9, 2024
@jpkneller jpkneller deleted the jpkneller-patch-3 branch May 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants