Drop Python 3.8 and 3.9 Support #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will reach EOL this autumn. NumPy and other major scientific Python packages have already dropped support in mid-2023, see https://numpy.org/neps/nep-0029-deprecation_policy.html
typing.Set, typing.List and typing.Dict are deprecated in Python 3.9 and later
JostMigenda
force-pushed
the
JostMigenda/UpdatePythonSupport
branch
from
617ee4c
to
695ff68
Compare
|
Note: The integration tests are currently expected to fail on the |
Yes, let's do that! 3.10 introduces easier syntax for type annotations (which we should use more), and pattern matching which is a clear and nice alternative to many if-else checks. It will be nice to use those features in our code. |
NumPy and other major scientific Python packages have already dropped support in April 2024, see https://numpy.org/neps/nep-0029-deprecation_policy.html
shorthand syntax doesn’t work with strings; and we can’t use the class itself within its own definition
|
Done and ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for Python 3.8 and cleans up some backwards compatibility code.
Python 3.8 is scheduled to reach end-of-life this autumn; and many major packages in the scientific Python ecosystem already started dropping 3.8 support since April 2023.
@Sheshuk: If there are any places in the SNEWPY 2.0 code where support for Python 3.9 is holding us back, we can consider dropping 3.9 support as well. (NumPy and others started doing that in April 2024.)