Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic editor: prevent placeholder replacement (issue #98) #102

Conversation

makyen
Copy link
Contributor

@makyen makyen commented Aug 31, 2017

Resolves issue #98.
General prevention edit rules from replacing placeholders. Any edit rule based replacement which changes the number of placeholders is prevented on a replacement by replacement basis.
Adjust complimentaryClose edit rule to prevent it from replacing placeholders.
Adjust:

  • Code blocks, block to include the preceding line (required).
  • Link section, lsec, to include the preceding line if it exists.

…tes/etc.) [issue SO-Close-Vote-Reviewers#98]

  Add logic to prevent any edit rule from making a replacement which
    changes the number of each placeholder type (used for code/quotes/links/etc.).
  Change complimentaryClose edit rule to not change placeholders.
  Change "block" placeholder to include the blank line prior to code blocks,
    as it's required for the format.
  Change "lsec" placeholder to include a blank line prior to the link section,
    if one exists, as it's more aesthetically pleasing to keep at least one blank line.
@makyen makyen merged commit 2f390e6 into SO-Close-Vote-Reviewers:master Aug 31, 2017
@makyen makyen deleted the MagicEditor-prevent-placeholder-replacement branch September 7, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant