Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different filters depending on site #23

Closed
FelixSFD opened this issue Feb 28, 2017 · 2 comments
Closed

Different filters depending on site #23

FelixSFD opened this issue Feb 28, 2017 · 2 comments

Comments

@FelixSFD
Copy link
Member

If we add support for more pages in the SE-network, we should make lists that define, which filters are used on which site. This could be achieved by adding the interface FilterList and classes like StackOverflowFilterList and AskUbuntuFilterList that are implementing this interface

@Bhargav-Rao
Copy link
Member

Yes, this is quite simple to implement. Just like the command lists, we need to pass another object, for that. I'll try to find some time and implement it.

@Bhargav-Rao
Copy link
Member

I found a simpler way of doing this by passing the sitename as a parameter while doing the filters check, I refactored it in commit 65638f9.

Unlike the command lists, which was per room, the filters list is per site, hence my previous comment about passing an additional object, is not that suitable.

I am still to decide whether to have an interface FiltersList, or just leave it in the way I've done it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants