Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundFlow - making large pings in rooms easier #5

Closed
double-fault opened this issue Apr 25, 2018 · 8 comments
Closed

SoundFlow - making large pings in rooms easier #5

double-fault opened this issue Apr 25, 2018 · 8 comments
Labels
bot-idea For issues that suggest a new bot idea. gh-approved For bot-ideas that have been approved by the GitHub admins and are allowed to create a repo

Comments

@double-fault
Copy link
Member

double-fault commented Apr 25, 2018

Name of the bot: SoundFlow
General topic: Chatroom pings
Problem, the bot is supposed to solve:

In rare cases when we have to ping a number of users, say all the ROs, or the developers of a bot (where a number of people are collaborating), we need to think to remember all names, or check out the bot's page to see all its developers; instead of this, with SoundFlow, just write something like @Team/BotName, and all devs of that bot will be pinged.

Ideas for implementation:

Preferably, all the teams should be stored in a file on GH; commands manipulating them will just add unnecessary complexity, which is not needs as teams don't change everyday. A privilege system should be important, especially for some teams like all ROs.

The bot will need to listen to two different name, @SoundFlow, and @Team/blah. Some basic commands like stop, reboot etc. will be useful. Redunda integration is also a very useful step IMHO.

Once the @Team/blah has been used, the bot should recognise the team, and post a message pinging all the users.


Pinging has been a very controversial idea in the past, especially mass pings. If anyone has objections, please post a comment.

@Bhargav-Rao Bhargav-Rao added the bot-idea For issues that suggest a new bot idea. label Apr 25, 2018
@Filnor
Copy link
Member

Filnor commented Apr 25, 2018

You mentioned a privilege system. I think that should be used to prevent abuse (because mass pings would be a perfect bait for trolls and such).

@Bhargav-Rao
Copy link
Member

Perhaps restrict pings to Room Owners/Moderators, but have the name display to everyone?

@double-fault
Copy link
Member Author

@pbdevch @Bhargav-Rao I do agree that a privilege system is extremely important. Maybe allow all ROs/mods, and a specific set of users who are regulars in the room? I also like the idea to have the names display to everyone.

@ArcticEcho ArcticEcho added in-discussion For bot-ideas that are still being discussed/pending approval. gh-approved For bot-ideas that have been approved by the GitHub admins and are allowed to create a repo and removed in-discussion For bot-ideas that are still being discussed/pending approval. labels May 5, 2018
@Bhargav-Rao
Copy link
Member

This would be a good addition. Anybody has any thoughts on developing it?

@Filnor
Copy link
Member

Filnor commented Jul 2, 2018

I would throw in myself for developing it, but I have some objections and questions before I could start:

Account

Done.
I think it's good idea to create a new bot account (called SoundFlow), but for development, I could use CheckYerFlags' account for the start.
Maybe a mod/RO wants to help out doing the required edits for the bot account?

User storing

Done.
The easiest way to ping the users would be by storing their name plaintext in the file, something along:

"users": [
    "Filnor",
    "CheckYerFlags"
]

But that would raise problems if a user changes their display name, so I think it would be better to store the user ID's and then fetch the display name/pingeable name using the chat lib.

Initial team/bot list

Done.
For the start and testing, it would be nice to have a list of teams and users.

Privilege system/trusted regulars

Done. Created a list with users I'm very confident to be trustworthy.
As previously discussed here, the access to the bot should be restricted to ROs, moderators and a specific set of regulars in the room. Who exactly would that regulars be?

Other things

  • I would propose Thunder integration alongside Redunda, as Thunder wasn't a thing back when this was created (IIRC)
  • I know Python for bot programming (CheckYerFlags and ChatCradle) and would go with that again, if that's OK.

@double-fault
Copy link
Member Author

double-fault commented Jul 3, 2018

What do you mean by thunder integration?

I have a slightly different method of implementation, but I’m very busy right now, sorry. Thanks @Filnor for taking the responsibility to develop this!

@Filnor
Copy link
Member

Filnor commented Jul 3, 2018 via email

@Filnor
Copy link
Member

Filnor commented Aug 28, 2018

Please redirect any further discussions & comments as issues in the SoundFlow repository, so we can close this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-idea For issues that suggest a new bot idea. gh-approved For bot-ideas that have been approved by the GitHub admins and are allowed to create a repo
Projects
None yet
Development

No branches or pull requests

4 participants