pulling sourceforge changes and dll/so copy issue #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidorovis
commented
Jul 17, 2012
sidorovis
commented
- auto copy mysql dll (so) to binary folder (mysql tests could be runned without adding dll (so) to ;
- commenting two test on mysql that have problems on MySQL 5.5.25a
- change type=InnoDB to ENGINE=InnoDB;
- adding SOCI_MYSQL_TEST_CONNSTR to auto insert CMake parameter into test;
Add functions for working with sequences/auto-increment fields in a portable and backend-independent way.
This constructor could never compile as it lacked the const_cast<> needed to assign its const parameter to non-const member reference. It also didn't set readOnly_ member to true correctly. Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
There is no need for a separate type for "unsigned long" as we don't have special types neither for "unsigned int" nor for "long" and this type was not handled correctly in the ODBC backend that mapped "unsigned int" to SQL_BIGINT, even though the former is almost always 32 bits and the latter is always 64 bits. Simply remove these types to avoid the problem and simplify the code. Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
Map "unsigned short/int/long" to "short/int/long" instead of "unsigned long long" they were all mapped to before. Unsigned variants can be compared to the signed ones and back without loss but "unsigned long long" has a different size and so can't always be converted from. Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
Calling convert_from_base() for the input ("use") parameters was unnecessary
and potentially confusing to the client code. Simply don't do this, just as we
don't call convert_to_base() for the output ("into") parameters.
Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
Oracle ODBC driver silently (!) doesn't support SQL_BIGINT ODBC type. Add a workaround to allow using 64 bit integers with it by passing them to/from the database as strings. Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
…rate connection string from CMake parameter, commented not working tests on 5.5.25a MySQL, change type=InnoDB to ENGINE=InnoDB
|
The idea of .bat scripts generating Visual Studio solutions is a good one, but the proposed scripts seem to be too specific to author's environments. So, I'm not going to merge these scripts. Instead, I made a new ticket for this idea to implement in more generic way, so it won't be forgotten: #41 |
|
I think this ticket has been cleared now and can be closed. Thanks to everyone for your contributions! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.