Fix connection parsing in SOCI Firebird backend to handle spaces in values. #73
Conversation
…alues. Really parse the connection strings instead of just breaking them on spaces. This allows to detect errors such as not using "key=value" syntax at all but most importantly allows to use spaces inside the values, as can be necessary for the "service" parameter value when using embedded Firebird as the file names can contain spaces. Signed-off-by: Vadim Zeitlin <vz-soci@zeitlins.org>
|
Thank you a lot! The method for parsing was obviously too dumb. 18.02.2013, 17:38, "VZ" notifications@github.com:
С уважением, |
ghost
assigned 
Fix connection parsing in SOCI Firebird backend to handle spaces in values.
This commit rewrites
explodeISCConnectString()function to properly handle spaces in the values so that connection strings such asfirebird://user=UID password=PWD service="c:\Program Files\foo.fdb"work correctly (before we tried to open"c:\Programas a file).I don't know what is the exact syntax of SOCI connection strings supposed to be, in particular whether there is any quoting, so I didn't do anything fancy and just made the minimal changes necessary to make the paths with spaces in them to work.