Fix issue where KafkaClient ready flag was not set to true after succ…

…essful connection
SOHU-Co · Jul 5, 2017 · 05743a4 · 05743a4
1 parent 14b65e6
commit 05743a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/kafkaClient.js b/lib/kafkaClient.js
@@ -129,6 +129,7 @@ KafkaClient.prototype.connect = function () {
           return this.emit('error', error);
         }
         this.updateMetadatas(result);
+        this.ready = true;
         this.emit('ready');
       });
     });

diff --git a/test/test.kafkaClient.js b/test/test.kafkaClient.js
@@ -195,6 +195,7 @@ describe('Kafka Client', function () {
       client.once('error', done);
       client.once('ready', function () {
         client.brokerMetadata.should.not.be.empty;
+        client.ready.should.be.true;
         done();
       });
     });
@@ -208,6 +209,7 @@ describe('Kafka Client', function () {
       });
 
       client.on('error', function (error) {
+        client.ready.should.be.false;
         error.code.should.be.eql('ECONNREFUSED');
         done();
       });
@@ -222,6 +224,7 @@ describe('Kafka Client', function () {
       });
       client.once('error', done);
       client.once('ready', function () {
+        client.ready.should.be.true;
         client.brokerMetadata.should.not.be.empty;
         done();
       });