Fix issue where a commit could yield a result breaking connect async.…

…waterfall (#918)
SOHU-Co · Apr 9, 2018 · 5b11858 · 5b11858 · aikar · Apr 10, 2018
1 parent 5bd3d76
commit 5b11858
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/consumerGroup.js b/lib/consumerGroup.js
@@ -445,14 +445,19 @@ ConsumerGroup.prototype.connect = function () {
           self.options.onRebalance(self.generationId != null && self.memberId != null, callback);
           return;
         }
-        callback();
+        callback(null);
       },
       function (callback) {
         if (self.options.autoCommit && self.generationId != null && self.memberId) {
-          self.commit(true, callback);
+          self.commit(true, function (error) {
+            if (error) {
+              return callback(error);
+            }
+            callback(null);
+          });
           return;
         }
-        callback();
+        callback(null);
       },
       function (callback) {
         if (self.client.coordinatorId) {