Fix parseHost returning a string port instead of a number closes #1229

SOHU-Co · Apr 30, 2019 · d089ad0 · d089ad0
1 parent 7ee0583
commit d089ad0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/kafkaClient.js b/lib/kafkaClient.js
@@ -104,7 +104,7 @@ util.inherits(KafkaClient, Client);
 
 function parseHost (hostString) {
   const ip = hostString.substring(0, hostString.lastIndexOf(':'));
-  const port = hostString.substring(hostString.lastIndexOf(':') + 1);
+  const port = +hostString.substring(hostString.lastIndexOf(':') + 1);
   const isIpv6 = ip.match(/\[(.*)\]/);
   const host = isIpv6 ? isIpv6[1] : ip;
   return {

diff --git a/test/test.kafkaClient.js b/test/test.kafkaClient.js
@@ -133,7 +133,7 @@ describe('Kafka Client', function () {
       client.initialHosts.should.not.be.empty;
       client.initialHosts.length.should.be.eql(1);
       client.initialHosts[0].host.should.be.eql('localhost');
-      client.initialHosts[0].port.should.be.eql('9092');
+      client.initialHosts[0].port.should.be.eql(9092);
     });
 
     it('initial hosts should be parsed if multiple hosts are provided', function () {
@@ -146,15 +146,15 @@ describe('Kafka Client', function () {
       client.initialHosts.should.be.eql([
         {
           host: 'localhost',
-          port: '9092'
+          port: 9092
         },
         {
           host: '127.0.0.1',
-          port: '9093'
+          port: 9093
         },
         {
           host: '192.168.1.0',
-          port: '9094'
+          port: 9094
         }
       ]);
     });