Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating cases with user role including Has optional health facility #13077

Open
Candice-Louw opened this issue Apr 17, 2024 · 8 comments · Fixed by #13079
Open

Error when creating cases with user role including Has optional health facility #13077

Candice-Louw opened this issue Apr 17, 2024 · 8 comments · Fixed by #13079
Assignees
Labels
bug An error or misbehavior of an existing feature (ticket type)

Comments

@Candice-Louw
Copy link
Contributor

Bug Description

When creating a new user role (Users > User Roles > Create new user role) and assigning the Has optional health facility, an error occurs when a user with this user role tries to create a new case.

Reproduction Steps

  1. Create new user with user role Has optional health facility defined.
  2. Login as this user.
  3. Navigate to Cases > New Case
  4. Error appears.
    ...

Expected Behavior

No error appears.

Affected Area(s)

Web app

SORMAS Version

1.95.1

Android version/Browser

Chrome

User Role(s)

Hospital Informant (default role with Facility attached to it)

Server URL

No response

Additional Information

Error log by @obinna-h-n : hosp-info-casecreate-error-sormas-log.txt

@Candice-Louw Candice-Louw added the bug An error or misbehavior of an existing feature (ticket type) label Apr 17, 2024
@obinna-h-n obinna-h-n self-assigned this Apr 20, 2024
obinna-h-n added a commit that referenced this issue Apr 20, 2024
…ype in case controller if user facility is not null
obinna-h-n added a commit that referenced this issue Apr 24, 2024
…or-when-creating-cases-with-user-role-hospital-informant-with-associated-facility

#13077 - fixes error when creating a new case as hospital informant user with an associated facility
@richardbartha
Copy link
Contributor

Issue is not fixed! Error is still happening when a hospital informant wants to create a case!
log.txt

@richardbartha richardbartha reopened this May 8, 2024
@obinna-h-n
Copy link
Contributor

@richardbartha , this fix is expected to be available in the next release. what version did you test on. can you test with the dev branch to confirm your findings again.

@richardbartha
Copy link
Contributor

The testing was done on development branch!

Untitled.video.mp4

@richardbartha richardbartha reopened this May 15, 2024
@obinna-h-n
Copy link
Contributor

obinna-h-n commented May 15, 2024

thanks for this update. I will look into this.

@obinna-h-n
Copy link
Contributor

Hi @richardbartha ,
I have just tested this again with the development branch as of this moment.
This error is not coming up.

Can you share the details of the user you have used to test, your error maybe related to another problem not what has been reported in this issue.

I will ask @Candice-Louw to check from her side as well.

@Candice-Louw
Copy link
Contributor Author

Candice-Louw commented May 23, 2024

When testing on 1.97.0-SNAPSHOT (86e6370), the error did not appear anymore (at least not on my side).

@obinna-h-n
Copy link
Contributor

I will mark this issue as closed. thank you @Candice-Louw.

@richardbartha
Copy link
Contributor

Retested on latest development branch together with @obinna-h-n the issue is still there or at least a part of it.
Reopening the ticket in order to solve the remaining part of the issue!

@richardbartha richardbartha reopened this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or misbehavior of an existing feature (ticket type)
Projects
None yet
3 participants