Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurvNet Adaptations - Create new field “Suspicious case” to cases [2] #3419

Closed
1 task
Tracked by #10741
markusmann-vg opened this issue Nov 6, 2020 · 18 comments · Fixed by #4320
Closed
1 task
Tracked by #10741

SurvNet Adaptations - Create new field “Suspicious case” to cases [2] #3419

markusmann-vg opened this issue Nov 6, 2020 · 18 comments · Fixed by #4320
Assignees
Labels
android-app Affects the Android app backend Affects the web backend cases de Adaptations requested by or implemented for Germany feature A new feature to be developed (ticket type) import-export needs-refinement Refinement or further specification required qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@markusmann-vg
Copy link

markusmann-vg commented Nov 6, 2020

Situation Description

Feature Description

Create new field “Suspicious case” to cases

Case > case information

New field (DE only) –
“Verdachtsfall (de – de) | “Suspicious case” (en) [SurvNet field names: SuspicionNotConf; SuspicionNotDat; SuspicionNotPhysician; SuspicionNotPathOther]

If the answer is “suspicion not confirmed” then change case classification to “no case”.

Data Type: check box, date
Values (de-de) | (en)

Verdacht nicht bestätigt am | suspicous not confirmed
o Information durch Arzt/Ärztin| information provided by physician
o Nachweis eines anderen Erregers| detection of other pathogen
Data Type: Datum |date

  • Add to export

Possible Alternatives

Additional Information

@markusmann-vg markusmann-vg added the feature A new feature to be developed (ticket type) label Nov 6, 2020
@GabrielePoggensee
Copy link

IfSG relevant: § 11 (1) 1 c: Indication when a suspicion has not been confirmed

Data are transmitted to RKI

@kwa20
Copy link

kwa20 commented Dec 15, 2020

I would actually like to refine this issue so it makes more sense in Sormas.

Only show this checkbox if 'suspect case' is selected as the case classification. Only when 'suspicion not confirmed' is checked, show the date field and the two further check boxes. Also change the classification to 'no case' as already mentioned above.

Screen Shot 2020-12-15 at 10 02 38 PM

@MateStrysewske
Copy link
Contributor

Why do we need this checkbox in the first place? Shouldn't setting the case classification to "Not a case" be enough? This will also update the date of classification, so we'd basically only need the two additional checkboxes for German systems.

@kwa20
Copy link

kwa20 commented Dec 16, 2020

@MateStrysewske I'd like that solution because it's minimalistic. We could also then only show the two additional checkboxes when 'no case' is selected and use 'suspicion not confirmed' as a heading for the two.

@bernardsilenou
Copy link

@kwa20 I think we need to first investigate what is the epidemiological definition of suspicious case in term of RKI. In some countries, suspicious case == suspected case.
I am more in line of thinking as @maté, this may be a category of case classification and it is a very sensitive topic.
Please lets have a call and followup on it

@MateStrysewske
Copy link
Contributor

@bernardsilenou I didn't write anything like that. I don't think we need a new classification for this.

@kwa20
Copy link

kwa20 commented Dec 16, 2020

After discussing with @bernardsilenou and considering @MateStrysewske's comment, we suggest this solution:

Screen Shot 2020-12-16 at 6 08 41 PM

We map 'no case' to 'suspicion not confirmed' and use the date of classification for mapping to the date field in SurvNet. When a user sets the case classification to 'no case', the drop down field 'reason for this classification' should appear. There you can select the variables shown in the mock-up ('information provided by physician' and 'verification of different pathogen' are mapped to SurvNet). If other is selected, a free text field appears to specify the reason further. Since multiple options can be chosen in SurvNet, we would need to be able to do it in Sormas too. We thought that if we have checkboxes, it could get messy when more variables are added later on. Would something as displayed in the mock-up even be possible?

We also suggest to make this field available for everyone, not just the german servers since everyone can benefit from this. Generally, we are not quite happy with 'verification of different pathogen' because that doesn't necessarily mean, that the person can not be a case in regards to that disease, but we could not think of another way to properly map it to SurvNet.

@MateStrysewske
Copy link
Contributor

@kwa20 We don't have such a component right now and I don't know whether it makes sense to build one for the Vaadin application. Because of that, my current feeling is that we should probably go with checkboxes for now and do it in a more user-friendly way when using the new technology.

@kwa20
Copy link

kwa20 commented Dec 17, 2020

@MateStrysewske Ok, let's use checkboxes with the option of multiple entries then with the heading "Reason for this classification". We then have a free text field when other is selected. @bernardsilenou We should probably not give too many options for selecting the reason for now then, because it will get messy with very many checkboxes.

@markusmann-vg markusmann-vg added this to Sprint 99 Interactions in Product Backlog (deprecated) Jan 21, 2021
@markusmann-vg markusmann-vg moved this from Sprint 99 Interactions to Sprint 100 Interactions in Product Backlog (deprecated) Jan 22, 2021
@markusmann-vg markusmann-vg moved this from Sprint 100 Interactions to Sprint 99 Interactions in Product Backlog (deprecated) Jan 22, 2021
@markusmann-vg markusmann-vg changed the title SurvNet Adaptations - Create new field “Suspicious case” to cases SurvNet Adaptations - Create new field “Suspicious case” to cases [2] Jan 22, 2021
@vidi42 vidi42 added this to Backlog in Sprint Backlog Team Interactions (deprecated) via automation Jan 22, 2021
@cazacmarin cazacmarin self-assigned this Jan 29, 2021
@cazacmarin cazacmarin moved this from Backlog to In Progress in Sprint Backlog Team Interactions (deprecated) Jan 29, 2021
@vidi42 vidi42 added android-app Affects the Android app backend Affects the web backend cases de Adaptations requested by or implemented for Germany import-export vaadin-app Affects the Vaadin application labels Feb 1, 2021
@vidi42 vidi42 added this to Backlog in SORMAS Team 4 - TEC - Iteration Backlog via automation Feb 1, 2021
@vidi42 vidi42 moved this from Backlog to In Progress in SORMAS Team 4 - TEC - Iteration Backlog Feb 1, 2021
@MateStrysewske
Copy link
Contributor

MateStrysewske commented Feb 1, 2021

  • Add new fields to cases:
    • notACaseReasonNegativeTest, notACaseReasonPhysicianInformation, notACaseReasonDifferentPathogen, notACaseReasonOther: boolean, displayed as checkboxes
    • notACaseReasonDetails: text
  • Show the checkboxes only when the case classification is "Not a case"
  • Show the text field only when notACaseReasonOther is selected
  • Show the new fields directly below the case classification and add a small heading "Reason for this classification"
  • Add new fields to export

For the captions, see screenshot above

Sprint Backlog Team Application (deprecated) automation moved this from In Progress to Testing Feb 11, 2021
leventegal-she added a commit that referenced this issue Feb 11, 2021
…o-cases-2

#3419 - Create new field “Suspicious case” to cases
@MateStrysewske
Copy link
Contributor

App is broken because the database upgrade script is faulty. Please repair this as soon as possible.

Sprint Backlog Team Application (deprecated) automation moved this from Testing to In Progress Feb 11, 2021
cazacmarin pushed a commit that referenced this issue Feb 11, 2021
cazacmarin added a commit that referenced this issue Feb 11, 2021
…eReasonDetails

#3419 Create new field “Suspicious case” to cases - fixing missing co…
@cazacmarin
Copy link
Contributor

Fixed missing column in android app.

Sprint Backlog Team Application (deprecated) automation moved this from In Progress to Testing Feb 11, 2021
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Feb 12, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of Sormas version 1.57.0-snapshot
Following elements of the ticket have been validated.
Show the checkboxes only when the case classification is "Not a case"
Show the text field only when notACaseReasonOther is selected
Show the new fields directly below the case classification and add a small heading "Reason for this classification"
Add new fields to export

@raghupola-vg
Copy link
Contributor

raghupola-vg commented Feb 12, 2021

Imports doesn't work as expected when the newly added check boxes are marked with Yes.
sormas_cases_2021-02-12.xlsx

@raghupola-vg raghupola-vg reopened this Feb 12, 2021
Sprint Backlog Team Application (deprecated) automation moved this from Testing to In Progress Feb 12, 2021
@AndyBakcsy-she AndyBakcsy-she removed the qa-verified Issue has been tested and verified by QA label Feb 12, 2021
@cazacmarin
Copy link
Contributor

@raghupola-vg - please provide more details about how to reproduce import issue.
For now @markusmann-vg asked only for export. And not for import. Markus - should we also cover the import for this?

@markusmann-vg
Copy link
Author

@cazacmarin Yes, pls. also add it to import functionality

@cazacmarin
Copy link
Contributor

Another case linked to Import was opened (as the import is working generically and is not a part of the development of this CR. Export is working as expected + all other conditions).
As discussed yesterday with @raghupola-vg - we can close this CR and another one, linked only to Import functional, will be opened (was actually was already done)

Sprint Backlog Team Application (deprecated) automation moved this from In Progress to Testing Feb 16, 2021
@raghupola-vg raghupola-vg added the qa-verified Issue has been tested and verified by QA label Feb 16, 2021
cazacmarin pushed a commit that referenced this issue Feb 17, 2021
…ar only in case if 1 export does exist.
cazacmarin added a commit that referenced this issue Feb 17, 2021
…al-review-issues

#3419 - fixing spaces issue & #1754 - fixing `Shared Exports` to appe…
@fhauptmann fhauptmann added the SSD label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app backend Affects the web backend cases de Adaptations requested by or implemented for Germany feature A new feature to be developed (ticket type) import-export needs-refinement Refinement or further specification required qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
No open projects
Development

Successfully merging a pull request may close this issue.