Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic update of case outcome and person’s condition [5] #525

Closed
bernardsilenou opened this issue Mar 16, 2018 · 6 comments
Closed
Assignees
Labels
android-app Affects the Android app backend Affects the web backend cases

Comments

@bernardsilenou
Copy link

bernardsilenou commented Mar 16, 2018

I went to cases and search all Lassa cases that are death, I found a case. When I open to look at the case data, The present conditiion was death but the outcome was "not yet classified". This is inconsistecy in my openion

My suggestion is that if the present condition of a case is "death", then the outcome should authhomatically be changed to"deceased".
If outcome is changed to "diceased" then present condtion should also be changed to death.
The defauld outcome of "Not yet classified" is correct but should be linked with the present condition such that is the present condition is changed, then the outcome should also change accordingly.
Maybe Daniel and Gérard will have to confirm this.
Best,
Bernard

@ghost
Copy link

ghost commented Mar 16, 2018

@bernardsilenou Please do not put real case information on github.

Thanks

@MateStrysewske MateStrysewske added this to the Sprint 37 milestone Mar 21, 2018
@MateStrysewske MateStrysewske added discuss Discussion about whether or not the issue should or can be implemented required android-app Affects the Android app cases backend Affects the web backend labels Mar 21, 2018
@MateStrysewske
Copy link
Contributor

@MartinWahnschaffeSymeda We have to discuss whether we want to do this before we take care of the automatic case classification.

@MateStrysewske MateStrysewske removed the discuss Discussion about whether or not the issue should or can be implemented required label Mar 26, 2018
@MartinWahnschaffe MartinWahnschaffe added discuss Discussion about whether or not the issue should or can be implemented required 102XX labels Apr 3, 2018
@MartinWahnschaffe MartinWahnschaffe modified the milestones: Sprint 37, Product Backlog Apr 3, 2018
@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Apr 4, 2018

  • when a case outcome is set to deceased the related person should be set to dead (cause is the disease). This can also lead to the next point:
  • when a person condition is set to dead or burried the related no outcome cases have to be set to deceased. Disease is not relevant.
  • [ ] when a case outcome is set back to recovered or no outcome yet, the related person should be set to alive (if dead)
  • when a person condition is set to alive, the related deceased cases have to be set to no outcome yet.
  • this logic should be done in the server's facade logic not in the app
  • add unit tests that simulate this using the facade methods
  • in the app the logic should be done only for the edited case
  • the app synchronization logic has to take into account that pushing persons may require to pull cases again before pushing them

@hzi-braunschweig Please have a look at the above rules and let us know if this is correct.

@MartinWahnschaffe MartinWahnschaffe removed the discuss Discussion about whether or not the issue should or can be implemented required label Apr 4, 2018
@MartinWahnschaffe MartinWahnschaffe changed the title Inconsistency between outcome and present conditioin Inconsistency between outcome and present condition [5] Apr 4, 2018
@MartinWahnschaffe MartinWahnschaffe changed the title Inconsistency between outcome and present condition [5] 3 Automatic update of case outcome and person’s condition [5] Apr 6, 2018
@MartinWahnschaffe MartinWahnschaffe changed the title 3 Automatic update of case outcome and person’s condition [5] Automatic update of case outcome and person’s condition [5] Apr 9, 2018
@MartinWahnschaffe MartinWahnschaffe self-assigned this Apr 11, 2018
MartinWahnschaffe pushed a commit that referenced this issue Apr 12, 2018
 when a case outcome is set to deceased the related person should be set to dead (cause is the disease). This can also lead to the next point:
 when a person condition is set to dead or burried the related no outcome cases have to be set to deceased. Disease is not relevant.
 when a person condition is set to alive, the related deceased cases have to be set to no outcome yet.
 add unit tests that simulate this using the facade methods
MartinWahnschaffe pushed a commit that referenced this issue Apr 12, 2018
 in the app the logic should be done only for the edited case
@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Apr 12, 2018

Synchronization process was already working correct. During sync it pulls and pushes for each single entity, so after syncing the modified person the case changed on the server side is automatically transfered.

TODO:

  • edit tabs currently are not updating to the changed value
  • check if sync merges cases correctly -> outcome date is changed be app and server at the same time - this has to be considered during merge (it's not a merge conflict).
  • remove false sync conflicts: also check if server and app value is the same

MartinWahnschaffe pushed a commit that referenced this issue Apr 16, 2018
 edit tabs currently are not updating to the changed value
 check if sync merges cases correctly -> outcome date is changed be app and server at the same time - this has to be considered during merge (it's not a merge conflict).
 remove false sync conflicts: also check if server and app value is the same
Sprint Backlog Team Application (deprecated) automation moved this from Doing to Review Apr 16, 2018
@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Apr 17, 2018

  • when case outcome is set to deceased the persons cause of death should be set to the disease
  • when case outcome is set to no outcome, the person should be set back to alive
  • when case outcome is set and no outcome date is defined, the default should be now

Sprint Backlog Team Application (deprecated) automation moved this from Review to Doing Apr 17, 2018
MartinWahnschaffe pushed a commit that referenced this issue Apr 18, 2018
 when case outcome is set to deceased the persons cause of death should be set to the disease
 when case outcome is set to no outcome, the person should be set back to alive
 when case outcome is set and no outcome date is defined, the default should be now
Sprint Backlog Team Application (deprecated) automation moved this from Doing to Review Apr 18, 2018
@MateStrysewske MateStrysewske self-assigned this Apr 18, 2018
@MateStrysewske
Copy link
Contributor

MateStrysewske commented Apr 18, 2018

  • fix cause of death fields appearing even if the condition is set to alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app backend Affects the web backend cases
Projects
None yet
Development

No branches or pull requests

3 participants