[Cases - Symptoms Tab] Page can not be saved if a future date is set for 'Date of symptom onset'

[adinaflorea9]

Bug Description

In the 'Symptoms' tab, the page can not be saved, if there are no symptoms checked, but previously a future date was set for 'Date of symptom onset'.

Steps to Reproduce

1. Navigate to the 'Symptoms' tab of a case;
2. Select 'Yes' for one of the symptoms;
3. From the 'First symptom' dropdown that became editable after step 2, select the visible symptom;
4. In the 'Date of symptom onset' field that became editable after step 2, select a date in the future;
5. Unselect the 'Yes' from step 2 (or select 'No/Unknown');
6. Click 'Save' at the bottom of the page.

Actual Behavior

The 'First symptom' dropdown was cleared; the 'Date of symptom onset' field was not cleared and the user can not save the page.

Expected Behavior

The 'Date of symptom onset' field should be cleared and the user should be able to save the page.

Screenshots

System Details

• Device: Windows 10
• SORMAS version: 1.69.0-SNAPSHOT
• Android version/Browser: Chrome
• Server URL: local machine and test-de2.sormas.netzlink.com
• User Role: Admin, NatUser

Additional Information

[bernardsilenou]

I hope I understood this point.

• To me, I do not see it as a bug because in step 4., you entered a future date which is not allowed in the first place, so you are supposed to correct it or delete it, rather than the system doing it automatically.
• We should also remember that the onset date also exists on creation forms, so editing forms should not automatically override data documented during creation.

[bernardsilenou]

The 'First symptom' dropdown was cleared; the 'Date of symptom onset' field was not cleared and the user can not save the page. this is because this data can also be collected on creation forms leading to many cases having onset date not all NULL for all symptoms. This is very common for linelisting cases.

[kwa20]

@bernardsilenou Is there any reason why we allow entering the symptom onset date without symptoms on creation forms but prevent entering this field on symptoms tabs without specifying a symptom as yes? The latter makes sense but makes it inconsitent and prevents easy corrections.

[bernardsilenou]

@kwa20
prevent entering this field on symptoms tabs without specifying a symptom as yes

• the current logic existed before onset date was added to the creation form
• This was just a specification that we did not consider when we added the onset date on the creation form. You are right, it would be good to add this point you suggested, to allow users to edit the onset date on the edit form without choosing a symptom.

[roxanamlendea]

I tested it on my local machine (90242d6) and it seems like the error message part has been fixed, but further problems appeared after the fix:

• If you fill in the 'Date of Symptom Onset' in the Case Creation form, the date is no longer adopted on the Symptoms page;
• On the Symptoms tab, if you set a symptom to 'Yes' and you complete the 'Date of Symptom Onset' and Save, the date field is cleared;

[roxanamlendea]

Verified ticket on local environment using the latest version of Sormas 1.70.0-SNAPSHOT (48fad26) from the development branch.