Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "report" geo coordinates for case, contact, visit, task [2] #86

Closed
8 tasks done
MartinWahnschaffe opened this issue Jan 16, 2017 · 3 comments
Closed
8 tasks done
Assignees
Labels
android-app Affects the Android app backend Affects the web backend
Milestone

Comments

@MartinWahnschaffe
Copy link
Contributor

MartinWahnschaffe commented Jan 16, 2017

  • add ReportLat, ReportLon to case, contact, event and visit (api, backend, app)
  • add ClosedLat, ClosedLon to task (api, backend, app)
  • update data dictionary
  • fill fields based on phones GPS data
  • find a way to update the coordinates without messing up the save system/delaying further usage of the app
  • discuss what to do if these entities are created on a non-mobile device (e.g. by a supervisor) or the required permissions are not granted on the phone
  • test whether entity creation works
  • repair unit tests

Fake GPS location should allow us to test this in development. For testing within Android Studio, the emulator provides functionalities to set the phone's geo location.

@MartinWahnschaffe MartinWahnschaffe added dashboard android-app Affects the Android app backend Affects the web backend labels Jan 16, 2017
@MartinWahnschaffe MartinWahnschaffe added this to the Backlog milestone Jan 16, 2017
@MartinWahnschaffe MartinWahnschaffe changed the title Add "report" geo coordinates for case, contact, visit Add "report" geo coordinates for case, contact, visit, task Jan 17, 2017
@MartinWahnschaffe MartinWahnschaffe changed the title Add "report" geo coordinates for case, contact, visit, task Add "report" geo coordinates for case, contact, visit, task [2] Feb 2, 2017
@MartinWahnschaffe MartinWahnschaffe self-assigned this Feb 2, 2017
@MartinWahnschaffe MartinWahnschaffe modified the milestones: Sprint 13, Backlog Feb 2, 2017
@MartinWahnschaffe MartinWahnschaffe removed their assignment Feb 2, 2017
@MartinWahnschaffe MartinWahnschaffe modified the milestones: Backlog, Pilot Backlog Mar 27, 2017
@MartinWahnschaffe MartinWahnschaffe modified the milestones: Pilot Backlog, Backlog Apr 10, 2017
@MartinWahnschaffe MartinWahnschaffe modified the milestones: Sprint 23, Backlog Jul 31, 2017
@MateStrysewske MateStrysewske self-assigned this Aug 16, 2017
@MateStrysewske
Copy link
Contributor

MateStrysewske commented Aug 17, 2017

Problems that we need to take into account:

  • App could be closed before a location update is retrieved (in which case the onLocationChanged listener method will never be called) -> this could happen in situations where the network/GPS connection is very unstable
  • GPS could be turned off while creating a new case
  • Users could reject the location permission request
  • Cases could be created by a supervisor from within the web app

@MartinWahnschaffe
Copy link
Contributor Author

MartinWahnschaffe commented Aug 17, 2017

Solutions:

  • check GPS feature availability on startup of sormas - refuse if no gps available
  • poll GPS every 5 minutes
  • use last gps coordinates when a new case etc. is created and the coordiantes aren't older than 15 minutes

MateStrysewske added a commit that referenced this issue Aug 18, 2017
…closedLon to task, added LocationService that tracks the phone's GPS, added functionality to set coordinates when saving, app is not usable when GPS is not allowed/turned off

#261 - added 'None' health facility, healthFacilityDetails caption is updated according to the selected option
MateStrysewske added a commit that referenced this issue Aug 21, 2017
@MateStrysewske
Copy link
Contributor

MateStrysewske commented Aug 23, 2017

  • request GPS access permission on startup
  • remove network provider from LocationService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app backend Affects the web backend
Projects
None yet
Development

No branches or pull requests

2 participants