#9755 s2 s share requests directory #10161
Conversation
There was a problem hiding this comment.
Please switch the buttons here. The reason is that users will more frequently select something and then apply it then revoke it.
The address field is cut
Please move the buttons at the end of the line after the comment.
The first column is cut although there is enough space
...s-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/SormasToSormasFacadeEjb.java
Outdated
Show resolved
Hide resolved
...rc/main/java/de/symeda/sormas/backend/sormastosormas/entities/caze/CaseShareDataBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/de/symeda/sormas/backend/sormastosormas/entities/caze/CaseShareDataBuilder.java
Show resolved
Hide resolved
.../main/java/de/symeda/sormas/backend/sormastosormas/entities/event/EventShareDataBuilder.java
Show resolved
Hide resolved
...ormas/backend/sormastosormas/entities/eventparticipant/EventParticipantShareDataBuilder.java
Outdated
Show resolved
Hide resolved
...kend/src/main/java/de/symeda/sormas/backend/sormastosormas/share/ShareDataBuilderHelper.java
Outdated
Show resolved
Hide resolved
...n/java/de/symeda/sormas/backend/sormastosormas/share/outgoing/ShareRequestInfoFacadeEjb.java
Outdated
Show resolved
Hide resolved
sormas-ui/src/main/java/de/symeda/sormas/ui/sormastosormas/ShareRequestGrid.java
Show resolved
Hide resolved
The order of the buttons are set in a base class so it is the same for all pages and I didn't see any complaints from SORMAS users to change it. So I would say it is ok.
You should scroll to right to see the address and other columns
It is requested in the ticket that the comment is the last column
I will remove the caption of that column because it is not needed |
…e_requests_directory # Conflicts: # sormas-backend/src/main/java/de/symeda/sormas/backend/caze/CaseFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/contact/ContactFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/event/EventFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/event/EventParticipantFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/immunization/ImmunizationFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sample/SampleFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/data/processed/ProcessedDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/data/processed/ProcessedDataPersisterHelper.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/caze/ProcessedCaseDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/contact/ContactShareDataBuilder.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/contact/ProcessedContactDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/event/EventShareDataBuilder.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/event/ProcessedEventDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/event/SormasToSormasEventFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/eventparticipant/ProcessedEventParticipantDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/immunization/ProcessedImmunizationDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/entities/sample/ProcessedSampleDataPersister.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/origin/SormasToSormasOriginInfoFacadeEjb.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/share/incoming/SormasToSormasShareRequestFacadeEJB.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/share/outgoing/ShareRequestInfoService.java # sormas-backend/src/main/java/de/symeda/sormas/backend/sormastosormas/share/outgoing/SormasToSormasShareInfoFacadeEjb.java
…erge issues and sorting bug
|
@leventegal-she I'm not certain, are you still working on this? Are you going to address the inline comments from my last review? :) |
I changed as you suggested |
|
Ok I was confused as the comments were not resolved, my bad :) Good to go! |
Fixes #9755