Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8213 - Enter home address for existing persons #11771

Merged

Conversation

MateStrysewske
Copy link
Contributor

Fixes #8213

@sormas-vitagroup
Copy link
Contributor

List<Method> methods = Arrays.stream(location.getClass().getDeclaredMethods())
.filter(
m -> !Modifier.isStatic(m.getModifiers()) && !Modifier.isPrivate(m.getModifiers()) && m.getName().startsWith("get")
|| m.getName().startsWith("is"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "m.getName().startsWith("get") || m.getName().startsWith("is")" should be together in separate paranthesis

enablePersonFields(false);
person = FacadeProvider.getPersonFacade().getByUuid(pickedPerson.getUuid());
setPerson(person);
enablePersonFields(false, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when a person is picked then all fields are disabled no matter if they are empty or not. This does not satisfy the comment added by @adinaflorea9 in the ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Adina's comment is out of scope for this issue because it would involve a lot more changes (e.g. this would need to be done for all create forms that include person details, not only the case create form). I've created a follow-up issue for it: #11781

@sormas-vitagroup
Copy link
Contributor

@sergiupacurariu sergiupacurariu merged commit 70a685d into development Apr 4, 2023
@sergiupacurariu sergiupacurariu deleted the change-8213-enter_home_address_existing_persons branch April 4, 2023 09:47
@MateStrysewske MateStrysewske restored the change-8213-enter_home_address_existing_persons branch April 5, 2023 08:13
@MateStrysewske MateStrysewske deleted the change-8213-enter_home_address_existing_persons branch April 5, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow entering of home address for existing persons with empty home address [1]
3 participants