-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8213 - Enter home address for existing persons #11771
#8213 - Enter home address for existing persons #11771
Conversation
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=11771 |
List<Method> methods = Arrays.stream(location.getClass().getDeclaredMethods()) | ||
.filter( | ||
m -> !Modifier.isStatic(m.getModifiers()) && !Modifier.isPrivate(m.getModifiers()) && m.getName().startsWith("get") | ||
|| m.getName().startsWith("is")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "m.getName().startsWith("get") || m.getName().startsWith("is")" should be together in separate paranthesis
enablePersonFields(false); | ||
person = FacadeProvider.getPersonFacade().getByUuid(pickedPerson.getUuid()); | ||
setPerson(person); | ||
enablePersonFields(false, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when a person is picked then all fields are disabled no matter if they are empty or not. This does not satisfy the comment added by @adinaflorea9 in the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Adina's comment is out of scope for this issue because it would involve a lot more changes (e.g. this would need to be done for all create forms that include person details, not only the case create form). I've created a follow-up issue for it: #11781
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=11771 |
Fixes #8213