Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial event info for 2020-09-29 #320

Merged
merged 11 commits into from
Sep 9, 2020

Conversation

jcohen02
Copy link
Collaborator

@jcohen02 jcohen02 commented Sep 8, 2020

This PR includes the event information for the event scheduled for 2020-09-29.

The event is awaiting an ID and Indico registration link and there will likely be a couple of other updates to be made but in terms of making the basic event information available, this is ready to be merged once an ID and registration link are added.

Copy link
Member

@Chilipp Chilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcohen02! thanks a lot for your work here. The failures are totally not your fault. It's a python 2.7 thing, it cannot decode characters such as . So I replaced them here.

@vsoch: Do you think we can adapt the pdf-generation action to use python 3.7 (or 3.8) instead of 2.7? Then this would not be a problem anymore.

_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
@jcohen02
Copy link
Collaborator Author

jcohen02 commented Sep 8, 2020

Many thanks for making the fixes to this @Chilipp. Out of interest I just did a test run of the PDF generation in a local build of the pdf-generator docker container (as described here) and it seemed to generate a PDF without complaining about the quote characters. I guess an update to the Actions configuration will resolve this as you've suggested.

@Chilipp
Copy link
Member

Chilipp commented Sep 8, 2020

@eileen-kuehn: Could you please provide a registration url and an event-id?

  • registration url inserted
  • event-ID changed

@vsoch
Copy link
Collaborator

vsoch commented Sep 8, 2020

I'm not sure what action you are asking for on the pdf-generator - it installs python3 and uses pandoc to generate the output, and @jcohen02 reports that all is working - if you are able to find the issue in the entrypoint please let me know and I'd be happy to create a branch for testing.

@Chilipp
Copy link
Member

Chilipp commented Sep 8, 2020

it seemed to generate a PDF without complaining about the quote characters.

yep @jcohen02, this is probably because you used the default settings which does not extract any metadata from the markdown file. If you want to mimick the PDF generation locally, you need to run the docker build as such:

cp _events/talks/event-ID_UNKNOWN.md ci/
docker run --env-file ci/env.txt -it -v `pwd`:/github/workspace rseng/pdf-generator

This should fail with the same error as in the github action (well, now it works, as I changed the problematic characters)

@Chilipp
Copy link
Member

Chilipp commented Sep 8, 2020

if you are able to find the issue in the entrypoint please let me know and I'd be happy to create a branch for testing.

see rseng/pdf-generator#6, is it okay that way @vsoch?

@Chilipp
Copy link
Member

Chilipp commented Sep 8, 2020

@jcohen02, the PDF generation is failing because it's a forked PR. We'll do this later (actually it should not attempt to open a PR for forks, sorry about that)

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the correct indico URL for registration and did open registration already.
I still need some information about the actual schedule that I can properly fill the timetable.

The registered ID for the event is 27 so the file name should become event-027.md. @jcohen02, could you change it?

_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
_events/talks/event-ID_UNKNOWN.md Outdated Show resolved Hide resolved
@Chilipp
Copy link
Member

Chilipp commented Sep 9, 2020

The registered ID for the event is 27 so the file name should become event-027.md. @jcohen02, could you change it?

I am not @jcohen02, but I changed it 😉

@jcohen02
Copy link
Collaborator Author

jcohen02 commented Sep 9, 2020

Thanks for your work investigating the issues here @Chilipp, and for changing the event ID 🙂

@Chilipp
Copy link
Member

Chilipp commented Sep 9, 2020

alright, when the CI finishes, we can merge this PR. Thanks a lot @jcohen02 (although for your patience 😅)

@jcohen02
Copy link
Collaborator Author

jcohen02 commented Sep 9, 2020

No problem @Chilipp, not quite as straightforward as we had all hoped but a useful exercise nonetheless. Thanks for your help in resolving the issues.

@Chilipp
Copy link
Member

Chilipp commented Sep 9, 2020

there seems to be a problem with the site of personal website of @tscheypidi (https://www.pik-potsdam.de/research/members/dietrich) which is why the link checking in the CI is failing. But I suspect, PIK will resolve this soon, so I'll merge this PR despite the failure (see also #327)

@Chilipp Chilipp merged commit 016477e into SORSE:master Sep 9, 2020
@PYTHON3610
Copy link

I'm new to python and programming where and what can I do here

@vsoch
Copy link
Collaborator

vsoch commented May 11, 2022

hey @PYTHON3610 ! I think this event is now passed so we don't have further work on this particular site (until it or a similar event happens again) but if you want to join the society's slack (instructions here) https://society-rse.org/join-us/ you can probably get notified when there is a new/future effort to make something.

@PYTHON3610
Copy link

PYTHON3610 commented May 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants