Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting and linting checks to CI #48

Merged
merged 9 commits into from
May 11, 2024
Merged

Add formatting and linting checks to CI #48

merged 9 commits into from
May 11, 2024

Conversation

sombraSoft
Copy link
Contributor

@sombraSoft sombraSoft commented May 10, 2024 •
edited
Loading

  • added lint:ci script in package.json to run in CI
  • created CI workflow for github actions. It will now run for all PRs to develop and master branches
  • fixed 3 files that had lint warnings

AlbuquerqueRafael
AlbuquerqueRafael suggested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@AlbuquerqueRafael AlbuquerqueRafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado pelo PR @sombraSoft.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sombraSoft
Copy link
Contributor Author

@filipepacheco resolvi os conflitos, tá pronto pra subir

@filipepacheco filipepacheco merged commit 7abcf8e into SOS-RS:develop May 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonCRocha AndersonCRocha AndersonCRocha left review comments

@AlbuquerqueRafael AlbuquerqueRafael AlbuquerqueRafael approved these changes

@filipepacheco filipepacheco filipepacheco approved these changes

Assignees
No one assigned
Labels
ci waiting-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sombraSoft @AlbuquerqueRafael @filipepacheco @AndersonCRocha