Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ottoni 2021: 2 samples missing due to no exact sample ages #1183

Open
ivelsko opened this issue Jul 25, 2024 · 6 comments
Open

Ottoni 2021: 2 samples missing due to no exact sample ages #1183

ivelsko opened this issue Jul 25, 2024 · 6 comments

Comments

@ivelsko
Copy link
Contributor

ivelsko commented Jul 25, 2024

Bug description

The Ottoni 2019 dataset includes 2 samples that aren't in the host-associated metagenome table, although they are ancient dental calculus and I can't find any indication in the publication that they should be excluded from this table.

Samples:
ERS6256710 (3295-GR14)
ERS6256715 (3300-CT3)

Were these intentionally excluded, or should they be added?

Additional context

No response

@bbartholdy
Copy link
Contributor

It looks like it was @jfy133 that added this study

@jfy133
Copy link
Member

jfy133 commented Jul 25, 2024

I don't remember excluding anything on purpose...

However that was a long time ago and the GitHub app won't let me see what the reviewer said for some reason 😅

Screenshot_20240725-182315.png

If you don't see any reason to exclude them, I suggest making a PR to add the two missing samples and libraries :)

@ivelsko ivelsko changed the title Ottoni 2019 missing 2 samples Ottoni 2021 missing 2 samples Jul 30, 2024
@ivelsko
Copy link
Contributor Author

ivelsko commented Jul 30, 2024

Oops, I had the wrong date. The correct publication is Ottoni2021, not Ottoni2019. I corrected the issue title

@alexhbnr
Copy link
Collaborator

I also did some digging. For these two samples we have sequencing data, however, James wasn't able to determine the approx. sample age from the information provided by the authors and therefore removed them (see 30ab5e0).

I double-checked and I cannot infer the sample ages either. For the Romanian sample GR14, the publication from 1976 doesn't seem to appear online and, for the Italian sample CT3, the publication that the authors cite only talks about everything to the Neolithic but not about the Bronze Age.

According to our sample column specification, we follow the guidelines that

⚠️ if a sample has no age, and cannot be inferred (sediment only) it cannot be included in AncientMetagenomeDir!

The question here is now whether it is more important to have a clean sample table or be inclusive regarding the sequencing data. @jfy133 @aidaanva

@jfy133
Copy link
Member

jfy133 commented Jul 31, 2024

Ah indeed, I think I forgot because most of that investigation was via private chat with the first author.

iMO I wanted a clean table at least with age, as that is a critical piece of info. Without which the 'ancient' definition is very questionable and not verifiable.

You could change this is you want but you may have to bqcl through all previous papers as there are a couple of others (only a handful mind) that have the same problem. I'm hindsight I should have probably recorded that, sorry about that

@alexhbnr
Copy link
Collaborator

OK, I will put it on the to do list to take a vote in the next AMDir core team meeting. If we agree to do it, it might be something for a next hackathon that we want to have at the end of the year.

@alexhbnr alexhbnr changed the title Ottoni 2021 missing 2 samples Ottoni 2021: 2 samples missing due to no exact sample ages Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants