Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brealey 2021 #432

Merged
merged 5 commits into from Sep 28, 2021
Merged

Add Brealey 2021 #432

merged 5 commits into from Sep 28, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 10, 2021

Pull Request

This PR is for a

For the following list(s):

  • ancientmetagenome-anthropogenic (README)
  • ancientmetagenome-environmental (README, ask @thedir-team-dirt for advice)
  • ancientmetagenome-hostassociated (README, ask @thedir-team-bugparty for advice)
  • ancientsinglegenome-hostassociated (README, ask @thedir-team-pathopeeps for advice)

New Publication

Publication Information

This pull request is to add samples from the following publication(s): 10.1016/j.cub.2021.08.010

This is to close #426

Checklist

  • Publication is published (preprints currently not accepted)?
  • Checked the publication is not already in the database?
  • Checked samples in this publication are not previously published data (newly re-sequenced metagenomes are OK!)?
  • Samples are shotgun metagenomes (hostassociated-singlegenome may also contain whole-genome enriched data)?
  • Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
  • Changelog is updated to include the publication under 'Added'?
  • [] Pull request has passed validation checks (see automated comment from github-bot)?
  • Review requested from corresponding team (see list of lists above for each team)?
  • (If applicable) Made a separate PR to add new categories to controlled lists (stored under /assets/enums, e.g. material or archive)? If so the corresponding PR is here:
If you do not know how to check errors in failed validation checks, expand here

Correction

This PR is for

  • ancientmetagenome-hostassociated
  • ancientsinglegenome-hostassociated
  • ancientmetagenome-environmental
  • ancientmetagenome-anthropogenic

Reference

This pull request is to correct samples from the following publication(s):

This is to close

Description

The issue is:

Checklist

  • Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
  • Changelog is updated to include the publication under 'Changed'?
  • Pull request has passed validation checks (see automated comment from github-bot)?
  • Review requested from corresponding team (see list of lists above for each team)?

@jfy133 jfy133 requested a review from a team September 10, 2021 07:45
@github-actions
Copy link

ancientMetagenomeDirCheck, version 1.2.1

Ancient Metagenome Host Associated

                        Validation Errors were found                        
┏━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Offending value ┃ Line number ┃    Column ┃ Error                        ┃
┡━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│            None │ 997         │ site_name │ None is not of type 'string' │
│            None │ 999         │ site_name │ None is not of type 'string' │
│            None │ 965         │ site_name │ None is not of type 'string' │
└─────────────────┴─────────────┴───────────┴──────────────────────────────┘
DatasetValidationError

@github-actions
Copy link

ancientMetagenomeDirCheck, version 1.2.1

Ancient Metagenome Host Associated

All is good, no errors were found !

Ancient Single Genome Host Associated

All is good, no errors were found !

Ancient Metagenome Environmental

All is good, no errors were found !

@ivelsko
Copy link
Contributor

ivelsko commented Sep 10, 2021

I think something is misaligned for this dataset. The lat/long coordinates and site_name don't align with the sample_name - for example UA021 has NA for lat/long but has entries in the publication table. I also can't match up the site_name with Spec.locality or Spec.parish in the published table. It looks like the published SampleID column got misaligned with the rest and now UaXXX samples are aligning with BEXXX sample information

@jfy133
Copy link
Member Author

jfy133 commented Sep 10, 2021

Uh oh... we had a much worse problem yesterday where something like that had indeed happened. I will check with Jaelle...

@github-actions
Copy link

ancientMetagenomeDirCheck, version 1.2.1

Ancient Metagenome Host Associated

All is good, no errors were found !

Ancient Single Genome Host Associated

All is good, no errors were found !

Ancient Metagenome Environmental

All is good, no errors were found !

@jfy133 jfy133 requested a review from ivelsko September 25, 2021 14:26
@jfy133
Copy link
Member Author

jfy133 commented Sep 25, 2021

If you check the latest Zenodo upload the metadata should be fixed now

@github-actions
Copy link

ancientMetagenomeDirCheck, version 1.2.1

Ancient Metagenome Host Associated

All is good, no errors were found !

Ancient Single Genome Host Associated

All is good, no errors were found !

Ancient Metagenome Environmental

All is good, no errors were found !

@jfy133 jfy133 merged commit aa10f9c into master Sep 28, 2021
@jfy133 jfy133 deleted the brealey2021 branch September 28, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brealey 2021
2 participants