Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmsh example updated for the latest Gmsh and Specfem2D #1204

Merged
merged 2 commits into from Feb 20, 2024

Conversation

mnagaso
Copy link

@mnagaso mnagaso commented Feb 20, 2024

No description provided.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7133e5) 54.64% compared to head (c759143) 54.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1204   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         164      164           
  Lines       30233    30233           
=======================================
  Hits        16520    16520           
  Misses      13713    13713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeter
Copy link
Contributor

great example, many thanks!

two suggestions for future use:

  1. let us choose a different name, to make the name a bit more explanatory about the example setup.

    -> i can do that as i'm going to create some new subfolder structure in the EXAMPLES/ similar to the 3D_Cartesian version, where we have benchmark, applications and reproducible_study subfolders.

  2. the Par_file ordering has changed slightly in the meantime, the nbmodels section is now mostly only used for internal meshes, whereas external meshes should use a MESH/nummaterial_velocity_file instead to define the material properities. you will find such an updated usage in the EXAMPLES/Gmsh_example_Stacey_MPI. this is to make the look-and-feel of the examples using external meshes in 2D and 3D_Cartesian versions more similar.

    -> i'll do that when updating the EXAMPLES/ folder soon...

@danielpeter danielpeter merged commit b735263 into SPECFEM:devel Feb 20, 2024
31 checks passed
@mnagaso
Copy link
Author

mnagaso commented Feb 20, 2024

Hi @danielpeter,

Thank you very much for merging my PR and explanation on how the material parameters should be set with external mesh currently!
I will modify my example to replace nbmodels to use MESH/nummaterial_velocity_file then reopen a merge request soon.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants